Skip to content

Use index instead of iterator to map positional and map keys for updates. #3930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Use index instead of iterator to map positional and map keys for updates. #3930

wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

No description provided.

@christophstrobl
Prepare issue branch.
390c37f
@christophstrobl
Use index instead of iterator to map position and map keys for updates.
1f6cb3a 
This commit removes usage of the iterator and replaces map key and positional parameter mappings with an index based token lookup.
@christophstrobl christophstrobl linked an issue Jan 11, 2022 that may be closed by this pull request
Set value of Map with numeric key breaks data structure #3921
Closed
@mp911de mp911de self-assigned this Jan 12, 2022
mp911de pushed a commit that referenced this pull request Jan 13, 2022
@christophstrobl @mp911de
Use index instead of iterator to map position and map keys for updates.
aeeac56 
This commit removes usage of the iterator and replaces map key and positional parameter mappings with an index based token lookup.

Closes #3921
Original pull request: #3930.
mp911de added a commit that referenced this pull request Jan 13, 2022
@mp911de
Polishing.
ee41609 
Simplify assertions, reformat code.

See #3921
Original pull request: #3930.
mp911de pushed a commit that referenced this pull request Jan 13, 2022
@christophstrobl @mp911de
Use index instead of iterator to map position and map keys for updates.
50a1212 
This commit removes usage of the iterator and replaces map key and positional parameter mappings with an index based token lookup.

Closes #3921
Original pull request: #3930.
mp911de added a commit that referenced this pull request Jan 13, 2022
@mp911de
Polishing.
d61cf8f 
Simplify assertions, reformat code.

See #3921
Original pull request: #3930.
mp911de pushed a commit that referenced this pull request Jan 13, 2022
@christophstrobl @mp911de
Use index instead of iterator to map position and map keys for updates.
f00e8ed 
This commit removes usage of the iterator and replaces map key and positional parameter mappings with an index based token lookup.

Closes #3921
Original pull request: #3930.
mp911de added a commit that referenced this pull request Jan 13, 2022
@mp911de
Polishing.
6c21eab 
Simplify assertions, reformat code.

See #3921
Original pull request: #3930.
@mp911de mp911de added the type: regression A regression from a previous release label Jan 13, 2022
@mp911de mp911de added this to the 3.2.8 (2021.0.8) milestone Jan 13, 2022
@mp911de
Copy link
Member

mp911de commented Jan 13, 2022

That's merged, polished, and backported now.

@mp911de mp911de closed this Jan 13, 2022
@mp911de mp911de deleted the issue/3921 branch January 13, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees

@mp911de mp911de

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
3.2.8 (2021.0.8)
Development

Successfully merging this pull request may close these issues.

Set value of Map with numeric key breaks data structure
2 participants
@christophstrobl @mp911de