Skip to content

Avoid creating invalid index definitions for Map-like properties #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Avoid creating invalid index definitions for Map-like properties #3915

wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

@christophstrobl christophstrobl commented Dec 17, 2021 •
edited
Loading

This commit makes sure to exclude Map like structures from index inspection unless annotated with @WilcardIndexed.

Resolves: #3914, #3901

@christophstrobl
Avoid creating invalid index definitions for Map like structures.
525240f 
This commit makes sure to exclude Map like structures from index inspection unless annotated with WilcardIndexed.
@christophstrobl christophstrobl mentioned this pull request Dec 20, 2021
Closed
@mp911de mp911de self-assigned this Jan 12, 2022
@mp911de mp911de added this to the 3.3.1 (2021.1.1) milestone Jan 12, 2022
@mp911de mp911de added the type: regression A regression from a previous release label Jan 12, 2022
mp911de pushed a commit that referenced this pull request Jan 12, 2022
@christophstrobl @mp911de
Avoid creating invalid index definitions for Map-like properties.
7f223d1 
This commit makes sure to exclude Map like structures from index inspection unless annotated with WilcardIndexed.

Closes #3914, closes #3901
Original pull request: #3915.
mp911de added a commit that referenced this pull request Jan 12, 2022
@mp911de
Polishing.
e9c15eb 
Reformat code. Tweak documentation wording and callout syntax.

See #3914, see #3901
Original pull request: #3915.
mp911de pushed a commit that referenced this pull request Jan 12, 2022
@christophstrobl @mp911de
Avoid creating invalid index definitions for Map-like properties.
e0a57fa 
This commit makes sure to exclude Map like structures from index inspection unless annotated with WilcardIndexed.

Closes #3914, closes #3901
Original pull request: #3915.
mp911de added a commit that referenced this pull request Jan 12, 2022
@mp911de
Polishing.
998bd1f 
Reformat code. Tweak documentation wording and callout syntax.

See #3914, see #3901
Original pull request: #3915.
@mp911de mp911de changed the title Avoid creating invalid index definitions for Map like structures. Avoid creating invalid index definitions for Map-like properties Jan 12, 2022
@mp911de
Copy link
Member

mp911de commented Jan 12, 2022

That's merged, polished, and backported now.

@mp911de mp911de closed this Jan 12, 2022
@mp911de mp911de deleted the issue/3914 branch January 12, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxblum jxblum Awaiting requested review from jxblum

Assignees

@mp911de mp911de

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
3.3.1 (2021.1.1)
Development

Successfully merging this pull request may close these issues.

MongoPersistentEntityIndexResolver should not traverse Map-like properties
2 participants
@christophstrobl @mp911de