Fix expression defining entire query in annotated repository methods #3907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s computed entirely via expression. This commit makes sure the extension collector returns a marker object to indicate no further json parsing is required.
This fix enables defining an entire JSON-based query in Query and Aggregate annotations using a single parameter or SpEL Expression.
Replace calls to deprecated methods. Remove unsed variables. Optimize imports.
spring-projects-issues
added
the
status: waiting-for-triage
rolag-it
changed the title
|
I just found the related issue #3874 fixed by @christophstrobl. My fix adds immediate expression result parsing as |
|
Hello @christophstrobl, I just merged your pull request, please take a look when you can. Thanks |
|
Thank you @rolag-it! We'll have a look (might take some time due to the upcoming holiday season though). |
...odb/src/main/java/org/springframework/data/mongodb/util/json/ParameterBindingJsonReader.java
Outdated
Show resolved
Hide resolved
Changed condition for Document parsing only when expression return a String
|
thanks @rolag-it! |
christophstrobl
added a commit
that referenced
this pull request
Jan 20, 2022
Add tests and move json string treatment into the ParameterBindingDocumentCodec. Finally add issue references and format code. Original Pull Request: #3907
|
Merged to main development line via (a8a0fb5). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix enables defining an entire JSON-based query in
@Queryand@Aggregateannotations use a single parameter or SpEL Expression.Examples: