Skip to content

Fix query/update document reference computation for non id properties. #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

We now consider using the target keyword when computing document references. This fixes an issue where query/update statements had not been rendered correctly for references like { 'name' : ?#{#target} }.

We now consider using the target keyword when computing document references. This fixes an issue where query/update statements had not been rendered correctly for references like { 'name' : ?#{#target} }.
mp911de pushed a commit that referenced this pull request Oct 7, 2021
We now consider using the target keyword when computing document references. This fixes an issue where query/update statements had not been rendered correctly for references like { 'name' : ?#{#target} }.

Closes #3853
Original pull request: #3856.
mp911de added a commit that referenced this pull request Oct 7, 2021
Reformat code.

See #3853
Original pull request: #3856.
@mp911de mp911de added the type: bug A general bug label Oct 7, 2021
@mp911de mp911de added this to the 3.3 RC1 (2021.1.0) milestone Oct 7, 2021
@mp911de
Copy link
Member

mp911de commented Oct 7, 2021

That's merged and polished now.

@mp911de mp911de closed this Oct 7, 2021
@mp911de mp911de deleted the issue/3853 branch October 7, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryMapper and UpdateMapper do not properly consider @DocumentReference to non-id properties
2 participants