-
Notifications
You must be signed in to change notification settings - Fork 1.1k
DATAMONGO-3587 - Support Evaluation Query Operators $expr. #3823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
divyajnu08
commented
Sep 14, 2021
- You have read the Spring Data contribution guidelines.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
Add support for Pattern. Extract Regex flags translation from Criteria into RegexFlags utility class. Add since and author tags. Simplify tests. Update reference documentation. See spring-projects#3725. Original pull request: spring-projects#3781.
Care to rebase your pull request? There are several commits that do not belong into this PR. |
Hi Mark The changes I made in MatchOperation were since I thought the now we can create a Criteria using the expression Criteria.expr(AggregationExpression) that can be passed to match operation existing constructor to create the match operation. Thanks |
Accidently it got deleted. Please find the PR for this. |
# Conflicts: # spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/MatchOperation.java # spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/aggregation/MatchOperationUnitTests.java
…ring-data-mongodb into feature/issue-3587
Thanks for taking the time to craft the PR and sorry for long radio silence. Unfortunately the expression gets evaluated right away without considering the context the query may be run in. This leads to invalid field references, because the |