Skip to content

GH-3726: Add support for $sampleRate aggregation operation #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
* @author Nikolay Bogdanov
* @author Gustavo de Geus
* @author Jérôme Guyon
* @author James McNee
* @since 1.3
*/
public class Aggregation {
Expand Down Expand Up @@ -478,6 +479,17 @@ public static SampleOperation sample(long sampleSize) {
return new SampleOperation(sampleSize);
}

/**
* Creates a new {@link SampleRateOperation} to select the documents from its input randomly using the provided sample rate.
*
* @param sampleRate must not be less than zero or more than one.
* @return new instance of {@link SampleRateOperation}.
* @since 3.2.4
*/
public static SampleRateOperation sampleRate(double sampleRate) {
return new SampleRateOperation(sampleRate);
}

/**
* Creates a new {@link MatchOperation} using the given {@link Criteria}.
*
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
/*
* Copyright 2017-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.data.mongodb.core.aggregation;

import org.bson.Document;
import org.springframework.util.Assert;

/**
* Encapsulates the {@code $sampleRate}-operation.
* <p>
* We recommend using the static factory method {@link Aggregation#sampleRate(double)} instead of creating instances of this
* class directly.
*
* @author James McNee
* @see <a href="https://docs.mongodb.com/manual/reference/operator/aggregation/sampleRate/">MongoDB Aggregation Framework:
* $sampleRate</a>
* @since 3.2.4
*/
public class SampleRateOperation implements AggregationOperation {

private final double sampleRate;

/**
* @param sampleRate sample rate to determine number of documents to be randomly selected from the input.
*/
public SampleRateOperation(double sampleRate) {
Assert.isTrue(sampleRate >= 0, "Sample rate must be greater than zero!");
Assert.isTrue(sampleRate <= 1, "Sample rate must not be greater than one!");
this.sampleRate = sampleRate;
}

/*
(non-Javadoc)
* @see org.springframework.data.mongodb.core.aggregation.BucketOperationSupport#toDocument(org.springframework.data.mongodb.core.aggregation.AggregationOperationContext)
*/
@Override
public Document toDocument(AggregationOperationContext context) {
return new Document(getOperator(), this.sampleRate);
}

/*
* (non-Javadoc)
* @see org.springframework.data.mongodb.core.aggregation.AggregationOperation#getOperator()
*/
@Override
public String getOperator() {
return "$sampleRate";
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/*
* Copyright 2017-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.data.mongodb.core.aggregation;

import org.bson.Document;
import org.junit.jupiter.api.Test;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;

/**
* Unit tests for {@link SampleRateOperation}.
*
* @author James McNee
*/
public class SampleRateOperationUnitTests {

private static final String OPERATION = "$sampleRate";

@Test // GH-3726
public void shouldRejectNegativeSampleRate() {
assertThatIllegalArgumentException().isThrownBy(() -> new SampleRateOperation(-1.0));
}

@Test // GH-3726
public void shouldRejectSampleRateGreaterThan1() {
assertThatIllegalArgumentException().isThrownBy(() -> new SampleRateOperation(1.1));
}

@Test // GH-3726
public void rendersSampleRateOperation() {
double sampleRate = 0.34;

SampleRateOperation sampleOperation = Aggregation.sampleRate(sampleRate);

Document sampleOperationDocument = sampleOperation.toDocument(Aggregation.DEFAULT_CONTEXT);

assertThat(sampleOperationDocument.get(OPERATION)).isNotNull();
assertThat(sampleOperationDocument.get(OPERATION)).isEqualTo(sampleRate);
}
}