Fix NPE when reading/mapping null value inside collection. #3691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Jul 1, 2021
| public <S extends Object> S convert(Object source, TypeInformation<? extends S> typeHint) { | ||
| public <S extends Object> S convert(@Nullable Object source, TypeInformation<? extends S> typeHint) { | ||
|
|
||
| if(source == null) { |
There was a problem hiding this comment.
Shouldn't that be rather caught in the map and collection iterations as we basically make convert nullable?
There was a problem hiding this comment.
The MappingMongoConverter does not follow the o.s.c.c.converter.Converter contract and accepted null in previous versions, though the documentation did state it differently. Since it's a public API, I'd rather restore the original behaviour and alter the documentation, than spread null checks in various places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3686