Skip to content

Fix conversion for Map/Collection like types having a converter registered. #3662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix conversion for Map/Collection like types having a converter registered. #3662

wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

Fixes: #3660

@dajulia3
Copy link
Contributor

dajulia3 commented Jun 7, 2021

Would love to see a fix for this merged in/released soon. I was super happy to see your PR :)... We have to roll back spring boot versions in the mean time :'(

mp911de pushed a commit that referenced this pull request Jun 9, 2021
@christophstrobl @mp911de
Fix conversion for types having a converter registered.
990696b 
Fixes: #3660
Original pull request: #3662.
mp911de added a commit that referenced this pull request Jun 9, 2021
@mp911de
Polishing.
ee203bf 
Reformat code.

See #3660.
Original pull request: #3662.
mp911de pushed a commit that referenced this pull request Jun 9, 2021
@christophstrobl @mp911de
Fix conversion for types having a converter registered.
ece261a 
Fixes: #3660
Original pull request: #3662.
mp911de added a commit that referenced this pull request Jun 9, 2021
@mp911de
Polishing.
2b715c5 
Reformat code.

See #3660.
Original pull request: #3662.
@mp911de mp911de added this to the 3.2.2 (2021.0.2) milestone Jun 9, 2021
@mp911de
Copy link
Member

mp911de commented Jun 9, 2021

That's merged and backported now.

@mp911de mp911de closed this Jun 9, 2021
@mp911de mp911de deleted the issue/3660 branch June 9, 2021 09:39
@mp911de mp911de added the type: regression A regression from a previous release label Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
3.2.2 (2021.0.2)
Development

Successfully merging this pull request may close these issues.

MappingMongoConverter problem: ConversionContext#convert does not try to use custom converters first
3 participants
@christophstrobl @dajulia3 @mp911de