Handle nested Pattern in Criteria equals #3615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
reviewed
Apr 8, 2021
| Document leftDocument = (Document) left; | ||
| Document rightDocument = (Document) right; | ||
|
|
||
| return isEqual(leftDocument.values(), rightDocument.values()); |
There was a problem hiding this comment.
An equality check for Map-like types requires a comparison of keys and values. Right now, a document could yield equality if only the order of values is the same regardless of the key the values are assigned to.
There was a problem hiding this comment.
Sorry, I totally missed that one. I fixed it now: the keys and the values are compared in the case of a Document.
mp911de
force-pushed
the
master
branch
2 times, most recently
from
7f55001 to
9d74734
Compare
mp911de
added
type: bug
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The equals method of
Patternreturns false if twoPatternsare equal but are different instances. This is already handled in theequalsmethod ofCriteriaand works well. However, sometimes aPatterncan be nested in aBasicDBListor in aDocumentor both, like in the case of a$oroperator.This PR fixes that: it enhances the
equalsmethod to manually compareBasicDBListsandDocumentsusing the customisEqualmethod. I am not aware of any util that allow to compare 2 collections using a customisEqualfunction so I had to implement it manually.Closes #3414