Skip to content

Return saved entity reference instead of original reference. #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

petitcl
Copy link
Contributor

@petitcl petitcl commented Mar 26, 2021

Make SimpleReactiveMongoRepository#saveAll(Publisher<S>) return the saved entity references instead of the original references.

Closes #3609

This is my first pull request, so I am sorry if am missing anything. Please tell me if something is missing and I will add it gladly.

I added a ReactiveImmutablePersonRepository and ImmutablePerson classes in SimpleReactiveMongoRepositoryTests but it would probably be better to create a dedicated test class that validates that immutable uses cases (including this one) are working.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Make SimpleReactiveMongoRepository#saveAll(Publisher<S>) return the saved entity references instead of the original references.

Closes spring-projects#3609
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 26, 2021
@mp911de mp911de self-assigned this Mar 29, 2021
@mp911de
Copy link
Member

mp911de commented Mar 29, 2021

Thanks a lot. We'll take your pull request from here.

mp911de pushed a commit that referenced this pull request Mar 29, 2021
Make SimpleReactiveMongoRepository#saveAll(Publisher<S>) return the saved entity references instead of the original references.

Closes #3609
Original pull request: #3611.
mp911de added a commit that referenced this pull request Mar 29, 2021
Omit StreamUtils usage if input is a collection. Remove superfluous Flux.from(…). Simplify test and migrate test to JUnit 5.

See #3609.
Original pull request: #3611.
mp911de pushed a commit that referenced this pull request Mar 29, 2021
Make SimpleReactiveMongoRepository#saveAll(Publisher<S>) return the saved entity references instead of the original references.

Closes #3609
Original pull request: #3611.
mp911de added a commit that referenced this pull request Mar 29, 2021
Omit StreamUtils usage if input is a collection. Remove superfluous Flux.from(…). Simplify test and migrate test to JUnit 5.

See #3609.
Original pull request: #3611.
mp911de pushed a commit that referenced this pull request Mar 29, 2021
Make SimpleReactiveMongoRepository#saveAll(Publisher<S>) return the saved entity references instead of the original references.

Closes #3609
Original pull request: #3611.
@mp911de
Copy link
Member

mp911de commented Mar 29, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Mar 29, 2021
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 29, 2021
@petitcl petitcl deleted the issue/3609 branch March 29, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimpleReactiveMongoRepository#saveAll does not populate @Id property if it is immutable
3 participants