Support expressions in query field projections. #3585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Mar 15, 2021
| * @param <T> | ||
| * @return never {@literal null}. | ||
| */ | ||
| default <T extends MongoExpression> T as(Function<MongoExpression, T> function) { |
There was a problem hiding this comment.
Intentionally did not name this one map, as I wanted to keep that method name available. I sounds like a better fit for getting called by the mapping layer to apply conversion.
| * @see org.springframework.data.mongodb.core.aggregation.DateOperators | ||
| * @see org.springframework.data.mongodb.core.aggregation.ObjectOperators | ||
| * @see org.springframework.data.mongodb.core.aggregation.SetOperators | ||
| * @see org.springframework.data.mongodb.core.aggregation.StringOperators @ |
| * @param json must not be {@literal null}. | ||
| * @return new instance of {@link MongoExpression}. | ||
| */ | ||
| static MongoExpression expressionFromString(String json) { |
There was a problem hiding this comment.
Two things:
- static import clashes with eg.
org.bson.Document.parse - the expression must not be evaluated immediately which is something I'd expect from
parse.
// explicit via dedicated AggregationExpression
query.fields()
.project(StringOperators.valueOf("name").toUpper())
.as("name");
// with a user provided expression parsed from a String
query.fields().project(MongoExpression.from("'$toUpper' : '$name'"))
.as("name")
// using SpEL support
query.fields().project(AggregationSpELExpression.expressionOf("toUpper(name)"))
.as("name");
// with parameter binding
query.fields().project(
MongoExpression.from("'$toUpper' : '?0'").bind("$name")
).as("name")
// via the @query annotation on repositories
@query(value = "{ 'id' : ?0 }", fields = "{ 'name': { '$toUpper': '$name' } }")
- MongoExpresssion#expressionFromString(String) -> MongoExpresssion#create - AggregationExpression#create(MongoExpression) ->A ggregationExpression#from - MongoExpression#as -> removed from public API
christophstrobl
force-pushed
the
issue/3583
branch
from
a2b25fb to
ff9d5a9
Compare
mp911de
pushed a commit
that referenced
this pull request
Mar 18, 2021
// explicit via dedicated AggregationExpression
query.fields()
.project(StringOperators.valueOf("name").toUpper())
.as("name");
// with a user provided expression parsed from a String
query.fields().project(MongoExpression.create("'$toUpper' : '$name'"))
.as("name")
// using SpEL support
query.fields().project(AggregationSpELExpression.expressionOf("toUpper(name)"))
.as("name");
// with parameter binding
query.fields().project(
MongoExpression.create("'$toUpper' : '?0'").bind("$name")
).as("name")
// via the @query annotation on repositories
@query(value = "{ 'id' : ?0 }", fields = "{ 'name': { '$toUpper': '$name' } }")
Closes: #3583
Original pull request: #3585.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with MongoDB 4.4 it is possible to use the aggregation expressions syntax for field projections as shown below.
@Query(fields='...')allows usage of expression field projections atRepositorylevel.Closes: #3583