Skip to content

MongoTransactionManager.debugString() always contains error #4241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kacz opened this issue Nov 30, 2022 · 1 comment
Closed

MongoTransactionManager.debugString() always contains error #4241

kacz opened this issue Nov 30, 2022 · 1 comment
Assignees
@christophstrobl
Labels
type: bug A general bug
Milestone
3.4.7 (2021.2.7)

Comments

@kacz
Copy link

kacz commented Nov 30, 2022

If server session is not null, String formatting in MongoTransactionManager.debugString() fails and therefore the output always contains "error = d != java.lang.Boolean".
The root cause is on line String.format("closed = %d, ", session.getServerSession().isClosed()) as boolean is not accepted by %d.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 30, 2022
@christophstrobl christophstrobl added the type: bug A general bug label Dec 2, 2022
@christophstrobl
Copy link
Member

Good catch @kacz! Should have been %b.

@christophstrobl christophstrobl removed the status: waiting-for-triage An issue we've not yet triaged label Dec 2, 2022
@christophstrobl christophstrobl self-assigned this Dec 2, 2022
@christophstrobl christophstrobl mentioned this issue Dec 2, 2022
Closed
@mp911de mp911de added this to the 3.4.7 (2021.2.7) milestone Jan 11, 2023
mp911de pushed a commit that referenced this issue Jan 11, 2023
@christophstrobl @mp911de
Fix invalid format specifier in debug statement.
6fa1800 
Closes #4241
Original pull request: #4246
mp911de pushed a commit that referenced this issue Jan 11, 2023
@christophstrobl @mp911de
Fix invalid format specifier in debug statement.
51f06d7 
Closes #4241
Original pull request: #4246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: bug A general bug
Projects
None yet
Milestone
3.4.7 (2021.2.7)
Development

Successfully merging a pull request may close this issue.

Fix invalid format specifier in debug statement. spring-projects/spring-data-mongodb
4 participants
@mp911de @christophstrobl @kacz @spring-projects-issues