Lost field value annotated with @MongoId

[wujimin]

problem

public class Model {
  @MongoId
  private String myId;
}

template.insert(new Model().setMyId("abc");

the value of "_id" saved to mongo:

• before upgrade: "abc"
• after upgrade: a new generated value

Possible Solutions

spring-data-mongodb/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/QueryOperations.java

Line 275 in a572580

if (entity == null) {

maybe should change this line to
if (entity == null || source.hasId()) {

[wujimin]

seems same to #4184

[christophstrobl]

I might be missing something but I cannot reproduce the issue on current main and 3.4.x branches.

class RawStringId {

	@MongoId String id;
	String value;
}

template.dropCollection(RawStringId.class);

RawStringId source = new RawStringId();
source.id = "abc";
source.value = "new value";

template.save(source);

org.bson.Document dbDoc = collection.find().limit(1).cursor().next();

assertThat(dbDoc).isNotNull();
assertThat(dbDoc.get("_id")).isEqualTo("abc");

Please take the time to provide a complete minimal sample (something that we can unzip or git clone, build, and deploy) that reproduces the problem.

[wujimin]

should invoke insert, not save

[christophstrobl]

ah - thank you very much @wujimin !

[wujimin]

you are welcome~