Skip to content

Factory beans should not contain protected setters. #3779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christophstrobl opened this issue Aug 23, 2021 · 0 comments
Closed

Factory beans should not contain protected setters. #3779

christophstrobl opened this issue Aug 23, 2021 · 0 comments
Assignees
@christophstrobl
Labels
type: task A general task
Milestone
3.2.5 (2021.0.5)

Comments

@christophstrobl
Copy link
Member

Setters in factory beans like MongoRepositoryFactoryBean should be public.
@christophstrobl christophstrobl added the type: task A general task label Aug 23, 2021
@christophstrobl christophstrobl self-assigned this Aug 23, 2021
christophstrobl added a commit that referenced this issue Aug 23, 2021
@christophstrobl
Change visibility of Reactive/MongoRepositoryFactoryBean setters.
1028df6 
Setters of the FactoryBean should be public.

Closes: #3779
@christophstrobl christophstrobl mentioned this issue Aug 23, 2021
Closed
mp911de pushed a commit that referenced this issue Aug 24, 2021
@christophstrobl @mp911de
Change visibility of Reactive/MongoRepositoryFactoryBean setters.
39f5f91 
Setters of the FactoryBean should be public.

Closes: #3779
Original pull request: #3780.
@mp911de mp911de added this to the 3.2.5 (2021.0.5) milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: task A general task
Projects
None yet
Milestone
3.2.5 (2021.0.5)
Development

No branches or pull requests
2 participants
@mp911de @christophstrobl