Skip to content

Relax requirement for GeoJsonMultiPoint construction allowing creation using a single point #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tinedel opened this issue Aug 21, 2021 · 0 comments
Closed

Relax requirement for GeoJsonMultiPoint construction allowing creation using a single point #3776

tinedel opened this issue Aug 21, 2021 · 0 comments
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
3.2.5 (2021.0.5)

Comments

@tinedel
Copy link
Contributor

tinedel commented Aug 21, 2021

I stumbled upon a limitation in GeoJsonMultipoint which I find unnecessary - it requires to have at least 2 points. While there are no requirements in GeoJson RFC for MultiPoint to have this and Mongo itself works just fine with 1 point in the coordinates list

Was there a reason to implement it like this? Will it cause backward compatibility issues if this requirement is relaxed?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 21, 2021
tinedel added a commit to tinedel/spring-data-mongodb that referenced this issue Aug 21, 2021
@tinedel
Relaxed requirement for GeoJsonMultiPoint to have 2 points.
0c015d2 
Only 1 point is required per GeoJson RFC and Mongo works just fine with 1 point as well.

Closes spring-projects#3776
tinedel added a commit to tinedel/spring-data-mongodb that referenced this issue Aug 21, 2021
@tinedel
Relaxed requirement for GeoJsonMultiPoint to have 2 points.
373f936 
Only 1 point is required per GeoJson RFC and Mongo works just fine with 1 point as well.

Closes spring-projects#3776
@tinedel tinedel mentioned this issue Aug 21, 2021
Closed
4 tasks
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 23, 2021
@mp911de mp911de self-assigned this Aug 25, 2021
@mp911de mp911de added this to the 3.2.5 (2021.0.5) milestone Aug 25, 2021
@mp911de mp911de changed the title GeoJsonMultipoint can be just one point Relax requirement for GeoJsonMultiPoint construction allowing creation using a single point Aug 25, 2021
@mp911de mp911de changed the title Relax requirement for GeoJsonMultiPoint construction allowing creation using a single point Relax requirement for GeoJsonMultiPoint construction allowing creation using a single point Aug 25, 2021
mp911de added a commit that referenced this issue Aug 25, 2021
@mp911de
Polishing.
f71f107 
Reorder methods. Add since tag. Simplify assertions. Use diamond syntax.

See: #3776
Original pull request: #3777.
mp911de pushed a commit that referenced this issue Aug 25, 2021
@tinedel @mp911de
Relax requirement for GeoJsonMultiPoint construction allowing creatio…
cb70a97 
…n using a single point.

Only 1 point is required per GeoJson RFC and Mongo works just fine with 1 point as well.

Closes #3776
Original pull request: #3777.
mp911de added a commit that referenced this issue Aug 25, 2021
@mp911de
Polishing.
3526b6a 
Reorder methods. Add since tag. Simplify assertions. Use diamond syntax.

See: #3776
Original pull request: #3777.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.2.5 (2021.0.5)
3 participants
@mp911de @tinedel @spring-projects-issues