Skip to content

Memory Leak: instances of UnwrappedMongoPersistentProperty are accumulating in PreferredConstructor.isPropertyParameterCache #3683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rogeriomgatto opened this issue Jun 23, 2021 · 3 comments
Closed

Memory Leak: instances of UnwrappedMongoPersistentProperty are accumulating in PreferredConstructor.isPropertyParameterCache #3683

rogeriomgatto opened this issue Jun 23, 2021 · 3 comments
Assignees
@christophstrobl
Labels
status: waiting-for-triage An issue we've not yet triaged
Milestone
3.2.3 (2021.0.3)

Comments

@rogeriomgatto
Copy link

UnwrappedMongoPersistentProperty doesn't implement equals() and hashCode() and is used as a key in PreferredConstructor.isPropertyParameterCache.
@christophstrobl christophstrobl self-assigned this Jun 23, 2021
@christophstrobl
Copy link
Member

Thanks for reporting!

@rogeriomgatto
Copy link
Author

Forgot to mention:
spring-data-mongodb version 3.2.1
mongodb-driver-sync version 4.2.3

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 23, 2021
@rogeriomgatto
Copy link
Author

Regarding urgency: this is a fast leak, MappingMongoConverter triggers this leak for read operations. Kubernetes is killing my pods.

christophstrobl pushed a commit that referenced this issue Jun 24, 2021
@christophstrobl
Add equals and hashCode to UnwrappedMongoPersistentProperty.
6644ac6 
Fixes #3683
Original Pull Request: #3684
@christophstrobl christophstrobl linked a pull request Jun 24, 2021 that will close this issue
Add equals and hashcode to UnwrappedMongoPersistentProperty (fixes #3683) #3684
Closed
@christophstrobl christophstrobl added this to the 3.2.3 (2021.0.3) milestone Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
3.2.3 (2021.0.3)
Development

Successfully merging a pull request may close this issue.

Add equals and hashcode to UnwrappedMongoPersistentProperty (fixes #3683)
3 participants
@rogeriomgatto @christophstrobl @spring-projects-issues