Skip to content

Relax field name checks for TypedAggregations. #3542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christophstrobl opened this issue Jan 21, 2021 · 0 comments
Closed

Relax field name checks for TypedAggregations. #3542

christophstrobl opened this issue Jan 21, 2021 · 0 comments
Labels
type: enhancement A general enhancement
Milestone
3.2 M3 (2021.0.0)

Comments

@christophstrobl
Copy link
Member

Mapping field names to domain type properties should not fail if a given field name does not correspond to a property of the target domain type as it might only be part of the document stored in MongoDB.

This would allow to eg. write aggregations like

Aggregation.newAggregation(group("_id").first("name").as("name"));

without having to project("id", "name") on the fields upfront.

Relates to: #3466
christophstrobl added a commit that referenced this issue Jan 25, 2021
@christophstrobl
Use relaxed type mapping for aggregations by default.
40f01e5 
This commit switches from a strict to a relaxed type mapping for aggregation executions. This allows users to add fields to the aggregation that might be part of the stored document but not necessarily of its java model representation.
Instead of throwing an exception in those cases the relaxed type check will go on with the user provided field names.
To restore the original behaviour use the strictMapping() option on AggregationOptions.

Closes #3542
@christophstrobl christophstrobl linked a pull request Jan 25, 2021 that will close this issue
Use relaxed type mapping for aggregations by default. #3545
Closed
@mp911de mp911de added this to the 3.2 M3 (2021.0.0) milestone Jan 27, 2021
@mp911de mp911de added the type: enhancement A general enhancement label Jan 27, 2021
mp911de added a commit that referenced this issue Jan 27, 2021
@mp911de
Polishing.
1d60cd7 
Tweak wording in the docs. Remove unused code. Fix generics. Rename AggregateContext to AggregationOperation to AggregationDefinition to avoid yet another Context object.

See #3542.
Original pull request: #3545.
@christophstrobl christophstrobl mentioned this issue Jan 27, 2021
Closed
@christophstrobl christophstrobl mentioned this issue Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.2 M3 (2021.0.0)
Development

Successfully merging a pull request may close this issue.

Use relaxed type mapping for aggregations by default. spring-projects/spring-data-mongodb
2 participants
@mp911de @christophstrobl