CodecRegistry not considered on a per-query basis [DATAMONGO-2557]

[spring-projects-issues]

rougou opened DATAMONGO-2557 and commented

I have a multi-tenant spring boot application that overrides getMongoDatabase to switch the database depending on the current tenant. I think it is a fairly common implementation.

After upgrading to Spring Boot 2.3 and Spring Data Mongo 3.0, I found a database call is now made at application startup for any @Query annotation. This prevents my app from even starting up since the database cannot be determined at that point.

Below is the line of code in question:

spring-data-mongodb/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/StringBasedMongoQuery.java

Line 113 in f09c622

CodecRegistry codecRegistry = mongoOperations.execute(MongoDatabase::getCodecRegistry);

 

Thanks

---

Affects: 3.0 GA (Neumann)

Issue Links:

• DATAMONGO-1894 Use reactive subscriber context for SpEL evaluation in query execution
  ("depends on")

Referenced from: pull request #879

[spring-projects-issues]

rougou commented

I should add that even without the multi-tenant requirement, it would be nice to be able to opt out of the call to getCodecRegistry and restore the original behavior. Though I don't pretend to understand the details

[spring-projects-issues]

rougou commented

For now, I have worked around this issue by returning a custom no-op MongoDatabase when the tenant can't be determined. It will return null for getCodecRegistry() and the default CodecRegistry will then be used

[spring-projects-issues]

Christoph Strobl commented

rougou would it be sufficient if the initialisation was delayed till the query is actually executed?

[spring-projects-issues]

rougou commented

Christoph Strobl Yes, that should work. My no-op database workaround is OK for now, so this is no longer a blocker for me. You can change the priority if necessary