SpringDataMongodbSerializer cannot convert query on nested id [DATAMONGO-1998]

[spring-projects-issues]

Simone Coletti opened DATAMONGO-1998 and commented

SpringDataMongodbSerializer is not able to correctly convert Predicate with clauses on nested _id (of type ObjectId), when the id is mapped to String in Document entity

---

Affects: 1.10.12 (Ingalls SR12), 2.0.7 (Kay SR7), 2.1 M3 (Lovelace)

Reference URL: querydsl/querydsl#1525

Issue Links:

• DATAMONGO-2010 SpringDataMongodbSerializer does not convert 'in' predicate for nested String id properties mapping to ObjectId

• DATAMONGO-1988 String ID not working for embeded objects

Referenced from: pull request #567

Backported to: 2.0.8 (Kay SR8), 1.10.13 (Ingalls SR13)

[spring-projects-issues]

Oliver Drotbohm commented

Would you mind giving a bit more context here? What do your domain objects look like, what kind of code are you executing? What's the result you get? What is the result you'd expect?

[spring-projects-issues]

Simone Coletti commented

Yes, sorry. I linked the GitHub ticket explaining the issue, and I thinked it was enough. 

So the scenario is this: I have 2 entities Doc1 and Doc2

@Document(collection = "coll1")
public class Doc1 implements Auditable<User, String> { 

   @Id
   private String id; // this will be ObjectId into mongodb

   private Doc2 embedded;

   // other props
}

 
@Document(collection = "coll2") 
public class Doc2 implements Auditable<User, String> { 
   @Id 
   private String id; // this will be ObjectId into mongodb
   // other props 
}

 

And I want to select all Doc1 entities whose embedded.id is included in a list:

doc1Repository.findAll(QDoc1.doc1.embedded.id.in(["A", "B", "C"])); // QueryDSL

The query expected is:

{ "embedded._id" : { "$in" : [ ObjectId("5af994976b80f32a0bc4d933") , ObjectId("5af994fb6b80f32a0bc4d934")]}}

instead I got:

{ "embedded._id" : { "$in" : [ "5af994976b80f32a0bc4d933" , "5af994fb6b80f32a0bc4d934"]}}

resulting in empty (obviously documents exist into the db)

[spring-projects-issues]

Simone Coletti commented

I've tried using version 1.10.14.BUILD-SNAPSHOT from http://repo.spring.io/snapshot (is it the right one?), but the error still occurs. Where can I get the right fixed library in order to test it?

[spring-projects-issues]

Oliver Drotbohm commented

Would you mind having a look at the fixing commit an see how your scenario derives from the tests we introduced? As the changes made for this ticket have already made it into the release today, would you mind creating an example that still reproduces the problem on 1.10.13?

[spring-projects-issues]

Simone Coletti commented

I'm trying to debug the code, but in the meanwhile I can tell you that the issue is now resolved for eq queries, in fact I changed 

doc1Repository.findAll(QDoc1.doc1.embedded.id.in(["A", "B", "C"]));

with

StringPath id = QDoc1.doc1.embedded.id;
doc1Repository.findAll(ExpressionUtils.anyOf(id.eq("A"), id.eq("B"), id.eq("C")));

and it works!

So the problem should be in converting String ids to ObjectId ids when the predicate is IN.

 

[spring-projects-issues]

Christoph Strobl commented

Thanks Simone Coletti - I've opened DATAMONGO-2010 for this