-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DATAJPA-1750 - Fixes order clause creation if function with parameter… #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
simonparadies
commented
Jun 28, 2020
•
edited
Loading
edited
- You have read the Spring Data contribution guidelines.
- There is a ticket in the bug tracker for the project in our JIRA.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
Thanks for looking into this. The problem, not with your PR, but with the current situation is, that the current approach of parsing the queries is not maintainable and need some serious work. I'd like to keep the PR open though, in order to eventually merge at least the tests, in order to verify everything works as intended. |
|
Backported to Thanks @simonparadies! |