Rewrite String queries for DTO Constructor Expressions #3654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seol-JY
reviewed
Nov 7, 2024
Comment on lines
77
to
90
| } else if (obj instanceof FactoryExpression) { | ||
| FactoryExpression<?> c = (FactoryExpression<?>) obj; | ||
| return args.equals(c.getArgs()) && getType().equals(c.getType()); |
There was a problem hiding this comment.
Suggested change
| } else if (obj instanceof FactoryExpression) { | |
| FactoryExpression<?> c = (FactoryExpression<?>) obj; | |
| return args.equals(c.getArgs()) && getType().equals(c.getType()); | |
| } else if (obj instanceof FactoryExpression<?> c) { | |
| return args.equals(c.getArgs()) && getType().equals(c.getType()); |
I recommend changing the instanceof check to use pattern matching feature.
christophstrobl
force-pushed
the
issue/3076
branch
from
d1b7545 to
02f7af5
Compare
…e is DTO. We now rewrite String-based JPA queries to use constructor expressions when either selecting the entity or selecting individual properties. We do not rewrite queries that already use constructor expressions. Closes #3076
Also, interface-based projections now use Tuple queries to consistently use tuple-based queries. Closes #2327
Refactor code duplications. See #2327
There's a difference in what the query needs to look like using dto vs. interface projections where the former does not allow column aliases and the latter requires them. See #2327
Simplify Querydsl templates retrieva and String query caching. Update documentation. Skip selection list rewriting if the returned type is an interface. Encapsulate rewrite information for Query. Reformat code. See #2327
Fix reference in javadoc
christophstrobl
force-pushed
the
issue/3076
branch
from
08ec727 to
79ab5ad
Compare
Introduce constructor compatibility check by checking assingable types.
christophstrobl
added a commit
that referenced
this pull request
Dec 17, 2024
Also fix a broken reference in javadoc. Original Pull Request: #3654
christophstrobl
pushed a commit
that referenced
this pull request
Dec 17, 2024
Introduce constructor compatibility check by checking assignable types. Original Pull Request: #3654
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3076
Closes #2327
Closes #3702