Suppress selection item aliasing for the actual count query #3553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now no longer apply count selection filtering but rather skip select field aliasing when rendering a count query to drop the field alias within a count query. Previously, we removed field aliasing by filtering the token stream which also removed the AS keyword from cast operators.
Fix typos, move QueryTransformers.filterCountSelection to CountSelectionTokenStream.create.
christophstrobl
pushed a commit
that referenced
this pull request
Aug 9, 2024
We now no longer apply count selection filtering but rather skip select field aliasing when rendering a count query to drop the field alias within a count query. Previously, we removed field aliasing by filtering the token stream which also removed the AS keyword from cast operators. Closes: #3536 Original Pull Request: #3553
christophstrobl
pushed a commit
that referenced
this pull request
Aug 9, 2024
We now no longer apply count selection filtering but rather skip select field aliasing when rendering a count query to drop the field alias within a count query. Previously, we removed field aliasing by filtering the token stream which also removed the AS keyword from cast operators. Closes: #3536 Original Pull Request: #3553
christophstrobl
pushed a commit
that referenced
this pull request
Aug 9, 2024
Fix typos, move QueryTransformers.filterCountSelection to CountSelectionTokenStream.create. Original Pull Request: #3553
christophstrobl
pushed a commit
that referenced
this pull request
Aug 9, 2024
We now no longer apply count selection filtering but rather skip select field aliasing when rendering a count query to drop the field alias within a count query. Previously, we removed field aliasing by filtering the token stream which also removed the AS keyword from cast operators. Closes: #3536 Original Pull Request: #3553
|
Merged to main and back ported to 3.3.x and 3.2.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now no longer apply count selection filtering but rather skip select field aliasing when rendering a count query to drop the field alias within a count query.
Previously, we removed field aliasing by filtering the token stream, which also removed the AS keyword from cast operators.
Closes #3536