Skip to content

Fix typo in README.adoc #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

soominsohn
Copy link
Contributor

Hi team,

This PR addresses an issue in the README file related to the usage example of the findByFirstnameLike method in Spring Data JPA.

Before

List<Person> firstNameResults = repository.findByFirstnameLike("Oli*");

After

List<Person> firstNameResults = repository.findByFirstnameLike("Oli%");

Using an asterisk (*) in the LIKE clause does not work for pattern matching in SQL. The proper wildcard character for the LIKE clause in SQL is the percentage symbol (%).

Thank you.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 1, 2024
@christophstrobl
Copy link
Member

good catch - thank you!

schauder pushed a commit that referenced this pull request Jul 4, 2024
The correct wildcard for JPQL is `%`.

Original pull request #3530
schauder pushed a commit that referenced this pull request Jul 4, 2024
The correct wildcard for JPQL is `%`.

Original pull request #3530
schauder pushed a commit that referenced this pull request Jul 4, 2024
The correct wildcard for JPQL is `%`.

Original pull request #3530
@schauder schauder added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 4, 2024
@schauder schauder self-assigned this Jul 4, 2024
@schauder schauder added this to the 3.2.8 (2023.1.8) milestone Jul 4, 2024
@schauder
Copy link
Contributor

schauder commented Jul 4, 2024

Thanks. That's merged.

@schauder schauder closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants