Skip to content

support Pageable.unpaged(sort). #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

yoa1226
Copy link

@yoa1226 yoa1226 commented Jun 17, 2024

@pivotal-cla
Copy link

@yoa1226 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@yoa1226 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 17, 2024
@yoa1226 yoa1226 changed the title support Pageable.unpaged(sort). Closes #3476 support Pageable.unpaged(sort). #3476 Jun 17, 2024
@yoa1226 yoa1226 changed the title support Pageable.unpaged(sort). #3476 support Pageable.unpaged(sort). Jun 17, 2024
@quaff
Copy link
Contributor

quaff commented Jun 17, 2024

You should add corresponding tests.

@yoa1226
Copy link
Author

yoa1226 commented Jun 17, 2024

You should add corresponding tests.

ok. I will.

yoa1226 added a commit to yoa1226/spring-data-jpa that referenced this pull request Jun 18, 2024
@yoa1226 yoa1226 force-pushed the feat/support_sort_when_unpaged branch from ae14b36 to e28059a Compare June 18, 2024 12:34
@yoa1226 yoa1226 force-pushed the feat/support_sort_when_unpaged branch from e28059a to 835aba0 Compare June 18, 2024 12:44
@yoa1226
Copy link
Author

yoa1226 commented Jun 18, 2024

@quaff hi, I added corresponding tests.

@christophstrobl christophstrobl self-assigned this Jul 1, 2024
@christophstrobl
Copy link
Member

Sorry @yoa1226 that one slipped through - closing this one as #3476 has been solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants