Skip to content

Change immediate String.format(…) evaluation to deferred #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dukbong
Copy link
Contributor

@dukbong dukbong commented Apr 24, 2024

This PR avoids unnecessary computations by changing the immediate evaluation using String.format to deferred evaluation with lambda expressions

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 24, 2024
@mp911de mp911de changed the title Change immediate evaluation to deferred evaluation. Change immediate String.format(…) evaluation to deferred Apr 25, 2024
mp911de pushed a commit that referenced this pull request Apr 25, 2024
mp911de added a commit that referenced this pull request Apr 25, 2024
@mp911de mp911de closed this in b9e6c24 Apr 25, 2024
mp911de added a commit that referenced this pull request Apr 25, 2024
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 25, 2024
@mp911de mp911de self-assigned this Apr 25, 2024
@mp911de mp911de added this to the 3.2.6 (2023.1.6) milestone Apr 25, 2024
@mp911de
Copy link
Member

mp911de commented Apr 25, 2024

Thank you for your contribution. That's merged and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants