Skip to content

Use Assert.notNull for null check #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

dukbong
Copy link
Contributor

@dukbong dukbong commented Apr 22, 2024

Use the Assert object for null checks.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 22, 2024
@mp911de
Copy link
Member

mp911de commented Apr 23, 2024

While this seems an improvement, the changed state introduces eager evaluation of String.format(…). I think the code lines stem from a time before Assert accepted a message supplier. Care to switch to a lambda syntax providing the message as () -> String.format(…)?

@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 23, 2024
@dukbong
Copy link
Contributor Author

dukbong commented Apr 23, 2024

While this seems an improvement, the changed state introduces eager evaluation of String.format(…). I think the code lines stem from a time before Assert accepted a message supplier. Care to switch to a lambda syntax providing the message as () -> String.format(…)?

Oh my god! @mp911de
Your feedback helped me revisit eager and lazy evaluation, allowing me to avoid unnecessary computations.
Thank you for helping me improve my code.

@mp911de
Copy link
Member

mp911de commented Apr 23, 2024

We're happy to help. Thanks a lot for the fast turnaround.

@mp911de mp911de self-assigned this Apr 23, 2024
@dukbong
Copy link
Contributor Author

dukbong commented Apr 23, 2024

We're happy to help. Thanks a lot for the fast turnaround.

I also appreciate the quick feedback. 😄
I'll continue to study hard to make great contributions in the future! 📚

@mp911de mp911de changed the title Use the Assert object for null checks. Use the Assert object for null checks Apr 23, 2024
@mp911de mp911de changed the title Use the Assert object for null checks Use Assert.notNull for null check Apr 23, 2024
@mp911de mp911de closed this in 1bf4c02 Apr 23, 2024
mp911de added a commit that referenced this pull request Apr 23, 2024
Reformat code.

See #3441
mp911de pushed a commit that referenced this pull request Apr 23, 2024
mp911de added a commit that referenced this pull request Apr 23, 2024
Reformat code.

See #3441
mp911de pushed a commit that referenced this pull request Apr 23, 2024
mp911de added a commit that referenced this pull request Apr 23, 2024
Reformat code.

See #3441
@mp911de
Copy link
Member

mp911de commented Apr 23, 2024

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de added this to the 3.1.12 (2023.0.12) milestone Apr 23, 2024
@dukbong
Copy link
Contributor Author

dukbong commented Apr 23, 2024

Thank you for your contribution. That's merged, polished, and backported now.

Thank you! I learned something new from today's open source activities!

@dukbong dukbong deleted the Line branch April 23, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants