Skip to content

Remove unnecessary javadoc from test code #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove unnecessary javadoc from test code #3333

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jan 26, 2024

Closes GH-3332

@quaff quaff mentioned this pull request Jan 26, 2024
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 26, 2024
mp911de
mp911de reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Changes improve our code quite a bit. I left a comment on @NonNull annotations that we typically do not use. Care to have a look?

@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 26, 2024
@mp911de mp911de changed the title Remove unnecessary javadoc from test code if method signature is self-described Remove unnecessary javadoc from test code Jan 26, 2024
@christophstrobl christophstrobl self-assigned this Jan 30, 2024
@christophstrobl
Copy link
Member

Thank you @quaff - resolved via 9912e48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

Assignees

@christophstrobl christophstrobl

Labels
type: task A general task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unnecessary javadoc from test code
4 participants
@quaff @christophstrobl @mp911de @spring-projects-issues