Fixes FileSystemException #3281
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
| Path logFile = Files.createTempFile("test-eclipselink-meta", ".log"); | ||
| LOG_FILE = logFile.toAbsolutePath().toString(); |
There was a problem hiding this comment.
how about making use of junits @TempDir leveraging automatic cleanup.
There was a problem hiding this comment.
Hi, thank you for the reply. Unfortunately with @TempDir there is the same problem...
@TempDir
static Path TMP;
@BeforeAll
static void createLogfile() throws IOException {
Path logFile = TMP.resolve("test-eclipselink-meta.log");
LOG_FILE = logFile.toAbsolutePath().toString();
}
There was a problem hiding this comment.
Generally switching to @TempDir is generally a good thing but we cannot fix the underlying problem that Eclipselink doesn't close the underlying logger. The offending code is in EntityManagerSetupImpl.
There was a problem hiding this comment.
@mp911de Let me know how I can resolve this issue, if my proposal to use temporary files is ok or if you prefer some other changes. I want to contribute, but I can't check my contribution without run the entire test suite. In the meantime, after further analysis, I can for sure open an issue, or a PR to the EclipseLink project. Thank you very much.
There was a problem hiding this comment.
Fixing the problem for you leaves us with temp directories that aren't cleaned up. So I think you could explore File.deleteOnExit().
There was a problem hiding this comment.
@mp911de Added with the latest commit. Thanks!
|
thank you @EdoardoP92 for bringing this up and taking the time to create a PR. |
@christophstrobl thank you too |
cagliostro92
force-pushed
the
fix-test-filesystemexception
branch
from
47ef27b to
6c0be21
Compare
|
@cagliostro92 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
mp911de
added
type: task
Under Windows operating system, unfortunately, I'm unable to build the JPA project because of a FileSystemException thrown at the act of delete the test-eclipselink-meta.log file in the EclipseLinkMetaAnnotatedQueryMethodIntegrationTests class. The proposal is to use a temporary file whose life cycle can be easily managed by the underlying operating system. Thanks in advance to the JPA team.