Make JpaSort.unsafe() operational for HQL, EQL, and JPQL. #3187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

gregturn wants to merge 2 commits into main from issue/gh-3172

Contributor

gregturn commented Oct 5, 2023

To support testing various configurations, I also implemente @HideHibernate, @HideEclipseLink, and @HidePersistenceProviders so that test methods and test classes can verify these classpath checks.


          Create branch.

26533a1

gregturn requested review from mp911de, schauder and christophstrobl

October 5, 2023 18:59

gregturn linked an issue

that may be closed by this pull request

Translate JpaSort.unsafe(…) used with Specifications to order-by Expression #3172

Closed

gregturn force-pushed the issue/gh-3172 branch from aa6b908 to 2e8805e Compare

October 5, 2023 19:11

Contributor Author

gregturn commented Oct 5, 2023

Considering it's a bug fix and all the new code is package-private (or private), then all the HQL and JPQL parts should be a candidate for backporting, at least to all versions that have query parsing.

However, to do so would ALSO require backporting the PersistenceProvider.isPresent from #3170 (which I'm in favor of).


          Make JpaSort.unsafe operational.

6aad414

We have offered this method as a way for people to customize an ORDER BY clause beyond a simple property name. For example, someone could use "LENGTH(firstname)" as a function to order by the length of each row's lastname instead of ordering by the lastname itself.

By using the relevant parser and applying a different visitor, this commit make operational a feature that shows little evidence of ever having worked.

See #3172.

gregturn force-pushed the issue/gh-3172 branch from 2e8805e to 6aad414 Compare

October 5, 2023 19:24

mp911de force-pushed the main branch from daebe31 to 1c37051 Compare

August 12, 2024 07:10

mp911de force-pushed the main branch 2 times, most recently from 52ee55f to 61e6d36 Compare

October 9, 2024 07:35

mp911de self-assigned this

mp911de added the type: enhancement label

mp911de added this to the 4.0 M2 (2025.1.0) milestone

mp911de pushed a commit that referenced this pull request


          Add visitor to build an order expression from a JPQL order specificat…

5fe789e

…ion.

We now parse JpaSort.unsafe(…) expressions using our Query Parser and translate the parsed tree into a CriteriaQuery Expression except for CAST, TREAT and subqueries.

Closes #3172
Original pull request: #3187

mp911de added a commit that referenced this pull request


          Polishing.

6c7509f

Refine temporal literal handling. Update documentation.

See #3172
Original pull request: #3187

Member

mp911de commented Jan 28, 2025

That's merged and polished now.

mp911de closed this

mp911de deleted the issue/gh-3172 branch

January 28, 2025 12:55

mp911de pushed a commit that referenced this pull request


          Add visitor to build an order expression from a JPQL order specificat…

648371b

…ion.

We now parse JpaSort.unsafe(…) expressions using our Query Parser and translate the parsed tree into a CriteriaQuery Expression except for CAST, TREAT and subqueries.

Closes #3172
Original pull request: #3187

mp911de added a commit that referenced this pull request


          Polishing.

b5aa7de

Refine temporal literal handling. Update documentation.

See #3172
Original pull request: #3187

mp911de pushed a commit that referenced this pull request


          Add visitor to build an order expression from a JPQL order specificat…

7b8b35f

…ion.

We now parse JpaSort.unsafe(…) expressions using our Query Parser and translate the parsed tree into a CriteriaQuery Expression except for CAST, TREAT and subqueries.

Closes #3172
Original pull request: #3187

mp911de added a commit that referenced this pull request


          Polishing.

020f4c2

Refine temporal literal handling. Update documentation.

See #3172
Original pull request: #3187

mp911de pushed a commit that referenced this pull request


          Add visitor to build an order expression from a JPQL order specificat…

2144aba

…ion.

We now parse JpaSort.unsafe(…) expressions using our Query Parser and translate the parsed tree into a CriteriaQuery Expression except for CAST, TREAT and subqueries.

Closes #3172
Original pull request: #3187

mp911de added a commit that referenced this pull request


          Polishing.

5c67e09

Refine temporal literal handling. Update documentation.

See #3172
Original pull request: #3187

mp911de pushed a commit that referenced this pull request


          Add visitor to build an order expression from a JPQL order specificat…

f7243a7

…ion.

We now parse JpaSort.unsafe(…) expressions using our Query Parser and translate the parsed tree into a CriteriaQuery Expression except for CAST, TREAT and subqueries.

Closes #3172
Original pull request: #3187

mp911de added a commit that referenced this pull request


          Polishing.

42ed969

Refine temporal literal handling. Update documentation.

See #3172
Original pull request: #3187

mp911de pushed a commit that referenced this pull request


          Add visitor to build an order expression from a JPQL order specificat…

b61c51d

…ion.

We now parse JpaSort.unsafe(…) expressions using our Query Parser and translate the parsed tree into a CriteriaQuery Expression except for CAST, TREAT and subqueries.

Closes #3172
Original pull request: #3187

mp911de added a commit that referenced this pull request


          Polishing.

3cb7e90

Refine temporal literal handling. Update documentation.

See #3172
Original pull request: #3187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement