Skip to content

Refine ref docs. #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Refine ref docs. #3006

wants to merge 2 commits into from

Conversation

gregturn
Copy link
Contributor

@gregturn gregturn commented Jun 7, 2023

No description provided.

gregturn added 2 commits June 7, 2023 10:54
@gregturn
Create branch.
4bc23f2
@gregturn
Add section to reference docs highlighting other possibilities.
56436e3 
Give users that have too complex of a query a list of where to go should Spring Data JPA not offer what they need in query support.

See #3005
@gregturn gregturn linked an issue Jun 7, 2023 that may be closed by this pull request
Add section to ref docs highlighting alternate strategies for implementing queries. #3005
Closed
@gregturn gregturn requested review from mp911de and schauder June 7, 2023 19:01
mp911de
mp911de reviewed Jun 8, 2023
View reviewed changes
src/main/asciidoc/jpa.adoc
In that situation, consider:

* If you haven't already, simply write the query yourself using <<jpa.query-methods.at-query,`@Query`>>.
* Sometimes, you can put your query inside the database use Spring Data JPA's <<jpa.stored-procedures,`@StoredProcedure` annotation>>, or if it's a database function use the <<jpa.query-methods.at-query,`@Query` annotation>> and invoke it with a `CALL`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mention stored procedures after recommending JdbcTemplate because it creates a tighter coupling with the database requirements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

gregturn added a commit that referenced this pull request Jun 8, 2023
@gregturn
Add section to reference docs highlighting other possibilities.
80916d4 
Give users that have too complex of a query a list of where to go should Spring Data JPA not offer what they need in query support.

See #3005
Original Pull Request: #3006
@gregturn gregturn closed this Jun 8, 2023
@gregturn gregturn deleted the issue/gh-3005 branch June 8, 2023 15:20
gregturn added a commit that referenced this pull request Jun 9, 2023
@gregturn
Add section to reference docs highlighting other possibilities.
107e4c1 
Give users that have too complex of a query a list of where to go should Spring Data JPA not offer what they need in query support.

See #3005
Original Pull Request: #3006
gregturn added a commit that referenced this pull request Jun 9, 2023
@gregturn
Add section to reference docs highlighting other possibilities.
f6d9b89 
Give users that have too complex of a query a list of where to go should Spring Data JPA not offer what they need in query support.

See #3005
Original Pull Request: #3006
@gregturn gregturn added this to the 3.0.7 (2022.0.7) milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

@schauder schauder Awaiting requested review from schauder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.7 (2022.0.7)
Development

Successfully merging this pull request may close these issues.

Add section to ref docs highlighting alternate strategies for implementing queries.
2 participants
@gregturn @mp911de