Skip to content

Leverage Hibernate's parser with custom visitors for HQL. #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Leverage Hibernate's parser with custom visitors for HQL. #3003

wants to merge 2 commits into from

Conversation

gregturn
Copy link
Contributor

@gregturn gregturn commented Jun 6, 2023

Rewrite the visitors for HQL to leverage Hibernate's custom parser.

@gregturn gregturn requested a review from mp911de June 6, 2023 18:11
@gregturn gregturn linked an issue Jun 6, 2023 that may be closed by this pull request
Migrate to Hibernate's official parser. #3002
Closed
@gregturn
Switch to Hibernate's official parser for HQL.
923d028 
Rewrite our custom visitors to plug into Hibernate's official parser for HQL.

See #3002
Original Pull Request: #3003
@gregturn gregturn force-pushed the issue/official-hql branch from 2f6de56 to 923d028 Compare June 6, 2023 18:11
@gregturn gregturn mentioned this pull request Jun 6, 2023
Closed
@gregturn gregturn requested a review from schauder June 6, 2023 19:41
@mp911de mp911de added the type: enhancement A general enhancement label Jun 7, 2023
@mp911de mp911de added this to the 3.2 M1 (2023.1.0) milestone Jun 7, 2023
@mp911de mp911de added the in: query-parser Everything related to parsing JPQL or SQL label Jun 7, 2023
gregturn added a commit that referenced this pull request Jun 8, 2023
@gregturn
Switch to Hibernate's official parser for HQL.
7c19a21 
Rewrite our custom visitors to plug into Hibernate's official parser for HQL.

See #3002
Original Pull Request: #3003
@gregturn gregturn closed this Jun 8, 2023
@gregturn gregturn deleted the issue/official-hql branch June 8, 2023 16:40
gregturn added a commit that referenced this pull request Jun 9, 2023
@gregturn
Switch to Hibernate's official parser for HQL.
9b0060d 
Rewrite our custom visitors to plug into Hibernate's official parser for HQL.

See #3002
Original Pull Request: #3003
gregturn added a commit that referenced this pull request Jun 9, 2023
@gregturn
Switch to Hibernate's official parser for HQL.
e1f4a61 
Rewrite our custom visitors to plug into Hibernate's official parser for HQL.

See #3002
Original Pull Request: #3003
@gregturn gregturn mentioned this pull request Jun 9, 2023
Closed
gregturn added a commit that referenced this pull request Jun 9, 2023
@gregturn
Switch to Hibernate's official parser for HQL.
e486fd1 
Rewrite our custom visitors to plug into Hibernate's official parser for HQL.

See #3002
Original Pull Request: #3003
@gregturn
Copy link
Contributor Author

Based on #3010 (comment), this PR is declined.

@gregturn gregturn removed this from the 3.2 M1 (2023.1.0) milestone Jun 12, 2023
@gregturn gregturn added the status: declined A suggestion or change that we don't feel we should currently apply label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

@schauder schauder Awaiting requested review from schauder

Assignees
No one assigned
Labels
in: query-parser Everything related to parsing JPQL or SQL status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to Hibernate's official parser.
2 participants
@gregturn @mp911de