Skip to content

Test against Java 21 on CI. #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pipeline {
when {
beforeAgent(true)
allOf {
branch(pattern: "main|(\\d\\.\\d\\.x)", comparator: "REGEXP")
branch(pattern: "issue/gh-java21|main|(\\d\\.\\d\\.x)", comparator: "REGEXP")
not { triggeredBy 'UpstreamCause' }
}
}
Expand Down
4 changes: 2 additions & 2 deletions ci/pipeline.properties
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Java versions
java.main.tag=17.0.6_10-jdk-focal
java.next.tag=20-jdk-jammy
java.next.tag=21-jdk-bullseye

# Docker container images - standard
docker.java.main.image=harbor-repo.vmware.com/dockerhub-proxy-cache/library/eclipse-temurin:${java.main.tag}
docker.java.next.image=harbor-repo.vmware.com/dockerhub-proxy-cache/library/eclipse-temurin:${java.next.tag}
docker.java.next.image=harbor-repo.vmware.com/dockerhub-proxy-cache/library/openjdk:${java.next.tag}

# Supported versions of MongoDB
docker.mongodb.4.4.version=4.4.18
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<groupId>org.springframework.data</groupId>
<artifactId>spring-data-jpa-parent</artifactId>
<version>3.2.0-SNAPSHOT</version>
<version>3.2.0-gh-java21-SNAPSHOT</version>
<packaging>pom</packaging>

<name>Spring Data JPA Parent</name>
Expand Down
4 changes: 2 additions & 2 deletions spring-data-envers/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@

<groupId>org.springframework.data</groupId>
<artifactId>spring-data-envers</artifactId>
<version>3.2.0-SNAPSHOT</version>
<version>3.2.0-gh-java21-SNAPSHOT</version>

<parent>
<groupId>org.springframework.data</groupId>
<artifactId>spring-data-jpa-parent</artifactId>
<version>3.2.0-SNAPSHOT</version>
<version>3.2.0-gh-java21-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,13 @@
*/
package org.springframework.data.envers.sample;

import lombok.EqualsAndHashCode;

import jakarta.persistence.GeneratedValue;
import jakarta.persistence.Id;
import jakarta.persistence.MappedSuperclass;

@MappedSuperclass
@EqualsAndHashCode
abstract class AbstractEntity {

public @Id @GeneratedValue Long id;

}
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@

import jakarta.persistence.Entity;

import lombok.ToString;
import org.hibernate.envers.Audited;

import java.time.Instant;

import org.hibernate.envers.Audited;

/**
* Sample domain class.
*
Expand All @@ -31,12 +30,15 @@
*/
@Audited
@Entity
@ToString
public class Country extends AbstractEntity {

public String code;

public Instant timestamp;

public String name;

public String toString() {
return "Country(code=" + this.code + ", timestamp=" + this.timestamp + ", name=" + this.name + ")";
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@
*/
package org.springframework.data.envers.sample;

import java.util.Set;

import jakarta.persistence.Entity;
import jakarta.persistence.ManyToMany;
import jakarta.persistence.Version;

import java.util.Objects;
import java.util.Set;

import org.hibernate.envers.Audited;

/**
Expand All @@ -32,10 +33,24 @@
@Entity
public class License extends AbstractEntity {

@Version
public Integer version;
@Version public Integer version;

public String name;
@ManyToMany
public Set<Country> laender;
@ManyToMany public Set<Country> laender;

@Override
public boolean equals(Object o) {

if (this == o)
return true;
if (o == null || getClass() != o.getClass())
return false;
License license = (License) o;
return Objects.equals(version, license.version) && Objects.equals(name, license.name);
}

@Override
public int hashCode() {
return Objects.hash(version, name);
}
}
2 changes: 1 addition & 1 deletion spring-data-jpa-distribution/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<parent>
<groupId>org.springframework.data</groupId>
<artifactId>spring-data-jpa-parent</artifactId>
<version>3.2.0-SNAPSHOT</version>
<version>3.2.0-gh-java21-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
4 changes: 2 additions & 2 deletions spring-data-jpa/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>org.springframework.data</groupId>
<artifactId>spring-data-jpa</artifactId>
<version>3.2.0-SNAPSHOT</version>
<version>3.2.0-gh-java21-SNAPSHOT</version>

<name>Spring Data JPA</name>
<description>Spring Data module for JPA repositories.</description>
Expand All @@ -15,7 +15,7 @@
<parent>
<groupId>org.springframework.data</groupId>
<artifactId>spring-data-jpa-parent</artifactId>
<version>3.2.0-SNAPSHOT</version>
<version>3.2.0-gh-java21-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
*/
package org.springframework.data.jpa.domain.sample;

import lombok.Getter;

import jakarta.persistence.GeneratedValue;
import jakarta.persistence.Id;
import jakarta.persistence.MappedSuperclass;
Expand All @@ -29,7 +27,8 @@
@MappedSuperclass
public abstract class AbstractMappedType {

@Id @GeneratedValue @Getter Long id;
@Id
@GeneratedValue Long id;
@Version Long version;
private String attribute1;

Expand All @@ -38,4 +37,8 @@ public abstract class AbstractMappedType {
AbstractMappedType(String attribute1) {
this.attribute1 = attribute1;
}

public Long getId() {
return this.id;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,43 @@
import jakarta.persistence.Entity;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.Id;
import lombok.AccessLevel;
import lombok.Data;
import lombok.NoArgsConstructor;

/**
* @author Greg Turnquist
*/
@Entity
@NoArgsConstructor(access = AccessLevel.PROTECTED)
@Data
public class EmployeeWithName {

@Id
@GeneratedValue private Integer id;
@GeneratedValue //
private Integer id;
private String name;

public EmployeeWithName(String name) {

this();
this.name = name;
}

protected EmployeeWithName() {}

public Integer getId() {
return this.id;
}

public String getName() {
return this.name;
}

public void setId(Integer id) {
this.id = id;
}

public void setName(String name) {
this.name = name;
}

public String toString() {
return "EmployeeWithName(id=" + this.getId() + ", name=" + this.getName() + ")";
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
import jakarta.persistence.IdClass;
import jakarta.persistence.JoinColumn;
import jakarta.persistence.Table;
import lombok.EqualsAndHashCode;
import lombok.ToString;

import java.util.Objects;

/**
* @author Mark Paluch
Expand All @@ -32,13 +32,13 @@
@Entity
@Table
@IdClass(ItemId.class)
@EqualsAndHashCode
@ToString
public class Item {

@Id @Column(columnDefinition = "INT") private Integer id;
@Id
@Column(columnDefinition = "INT") private Integer id;

@Id @JoinColumn(name = "manufacturer_id", columnDefinition = "INT") private Integer manufacturerId;
@Id
@JoinColumn(name = "manufacturer_id", columnDefinition = "INT") private Integer manufacturerId;

private String name;

Expand Down Expand Up @@ -72,4 +72,25 @@ public void setName(String name) {
this.name = name;
}

@Override
public boolean equals(Object o) {

if (this == o)
return true;
if (o == null || getClass() != o.getClass())
return false;
Item item = (Item) o;
return Objects.equals(id, item.id) && Objects.equals(manufacturerId, item.manufacturerId)
&& Objects.equals(name, item.name);
}

@Override
public int hashCode() {
return Objects.hash(id, manufacturerId, name);
}

public String toString() {
return "Item(id=" + this.getId() + ", manufacturerId=" + this.getManufacturerId() + ", name=" + this.getName()
+ ")";
}
}
Loading