Handle LIKE with ESCAPE clause in Hibernate and EclipseLink

[gregturn]

HQL parser currently only handles pure characters. It needs to handle a parameter if it's to support SpEL expressions. This lets us enable three test kits.

And NOW, the EclipseLink extension of those tests...must be disabled just like in 3.0.x.

NOTE: This patch should be candidate for backporting to 3.1.x as that also has the same parser.

[gregturn]

This has the fix for HQL in one commit and the fix for EclipseLink in another commit. We can review them both here. I think we should keep them as separate commits since each commit touches a different part of Spring Data JPA.

[mp911de]

We are replacing expressions with binding parameters. What's the reason to switch to an expression instead of using a binding parameter?

[gregturn]

Well, I was picking something that supported both character and parameter, which expression handles quite nicely (in the grammar). However, to really dial it in, I tweaked this line in the revised commit:

stringPatternMatching
    : expression NOT? (LIKE | ILIKE) expression (ESCAPE (character|parameter))?
    ;

And the clause rendering this portion:

if (ctx.ESCAPE() != null) {

	tokens.add(new JpaQueryParsingToken(ctx.ESCAPE()));
	if (ctx.character() != null) {
		tokens.addAll(visit(ctx.character()));
	} else if (ctx.parameter() != null) {
		tokens.addAll(visit(ctx.parameter()));
	}
}

This passes all our tests and makes it clear that we either take a character (as original intended) or we support a parameter via SpEL.

[mp911de]

That's merged and backported now.