DATAJPA-1443 - Remove incorrect JavaDoc in Specifications #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
changed the title
schauder
pushed a commit
that referenced
this pull request
Oct 17, 2018
The type parameter for Specifications.and and Specifications.or is not method specific. Therefore removed them from the JavaDoc. Original pull request: #295.
schauder
added a commit
that referenced
this pull request
Oct 17, 2018
Original pull request: #295. Fixed more JavaDoc warnings by completing parameter and return value description.
schauder
pushed a commit
that referenced
this pull request
Oct 17, 2018
The type parameter for Specifications.and and Specifications.or is not method specific. Therefore removed them from the JavaDoc. Original pull request: #295.
schauder
added a commit
that referenced
this pull request
Oct 17, 2018
Original pull request: #295. Fixed more JavaDoc warnings by completing parameter and return value description.
schauder
pushed a commit
that referenced
this pull request
Oct 17, 2018
The type parameter for Specifications.and and Specifications.or is not method specific. Therefore removed them from the JavaDoc. Original pull request: #295.
schauder
added a commit
that referenced
this pull request
Oct 17, 2018
Original pull request: #295. Fixed more JavaDoc warnings by completing parameter and return value description.
|
Thanks for spotting and fixing that. I created a Jira issue for this and merged it together with #296. |
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
The type parameter for Specifications.and and Specifications.or is not method specific. Therefore removed them from the JavaDoc. Original pull request: spring-projects#295.
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
Original pull request: spring-projects#295. Fixed more JavaDoc warnings by completing parameter and return value description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type parameter for
Specifications#andandSpecifications#oris not method specific and thus the according JavaDoc comments are incorrect.