Skip to content

Allow native SQL functions to have ';' as arguments #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Allow native SQL functions to have ';' as arguments #2891

wants to merge 2 commits into from

Conversation

gregturn
Copy link
Contributor

Original issue: #2884

gregturn added 2 commits March 27, 2023 14:01
@gregturn
New branch.
61fee3c
@gregturn
Support functions that have semicolons as arguments.
700b2a2 
A native SQL function with ';' as an argument, e.g. listagg(a.b, ';'), will fail to find anything after it (like an alias). By adding ';' to the list of approved function tokens, queries with functional aliases will work properly.

Resolves #2884.
@gregturn gregturn requested review from schauder and mp911de March 27, 2023 19:07
@gregturn gregturn linked an issue Mar 27, 2023 that may be closed by this pull request
Accept additional function argument literals for correct native query with pageable rewrite #2884
Closed
@mp911de mp911de self-assigned this Mar 28, 2023
mp911de pushed a commit that referenced this pull request Mar 28, 2023
@gregturn @mp911de
Support functions that have semicolons as arguments.
dc89da4 
A native SQL function with ';' as an argument, e.g. listagg(a.b, ';'), will fail to find anything after it (like an alias). By adding ';' to the list of approved function tokens, queries with functional aliases will work properly.

Resolves #2884.
Original pull request: #2891
mp911de added a commit that referenced this pull request Mar 28, 2023
@mp911de
Polishing.
e76a94e 
Simplify tests.

See #2884
Original pull request: #2891
mp911de pushed a commit that referenced this pull request Mar 28, 2023
@gregturn @mp911de
Support functions that have semicolons as arguments.
1534c87 
A native SQL function with ';' as an argument, e.g. listagg(a.b, ';'), will fail to find anything after it (like an alias). By adding ';' to the list of approved function tokens, queries with functional aliases will work properly.

Resolves #2884.
Original pull request: #2891
mp911de added a commit that referenced this pull request Mar 28, 2023
@mp911de
Polishing.
29467ef 
Simplify tests.

See #2884
Original pull request: #2891
@mp911de mp911de added the type: enhancement A general enhancement label Mar 28, 2023
@mp911de
Copy link
Member

mp911de commented Mar 28, 2023

That's merged, polished, and backported now.

@mp911de mp911de closed this Mar 28, 2023
@mp911de mp911de deleted the issue/gh-2884 branch March 28, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schauder schauder Awaiting requested review from schauder

@mp911de mp911de Awaiting requested review from mp911de

Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept additional function argument literals for correct native query with pageable rewrite
2 participants
@gregturn @mp911de