Recognize LEFT, RIGHT, INNER, OUTER, and FULL as reserved words #2874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Mar 21, 2023
| @@ -700,7 +700,7 @@ reservedWord | |||
| | FOR | |||
| | FORMAT | |||
| | FROM | |||
| // | FULL | |||
| | FULL | |||
There was a problem hiding this comment.
What about the JPQL grammar about FULL?
There was a problem hiding this comment.
I've copied the test cases I used to expose this issue in HQL into the JPQL-based tests. Looks like "RIGHT" is okay, but we need to add support for "LEFT", "INNER", and "OUTER".
gregturn
changed the title
mp911de
reviewed
Mar 22, 2023
| @@ -674,6 +674,121 @@ void orderByShouldWorkWithSubSelectStatements() { | |||
| + "GROUP BY i2.field.id, i2.version)", sort)).endsWith("order by i.age desc"); | |||
| } | |||
|
|
|||
| @Test // GH-2864 | |||
| void usingRightAsARelationshipNameShouldWork() { | |||
There was a problem hiding this comment.
These repetitive tests would shape up better as @ParametrizedTest
mp911de
reviewed
Mar 22, 2023
RIGHT, LEFT, OUTER, INNER, and FULL are HQL tokens. This means they also need to be recognized as potential reserved words and thus possibly identifiers. This can show up if someone, for example, uses "right" as the name of a relationship in a JPA entity. Resolves #2864.
gregturn
changed the title
|
Last commit tweaks things to use @ParameterizedTest. All the other commits are due to me rebasing the branch to pick up recent changes to |
mp911de
added
type: bug
mp911de
pushed a commit
that referenced
this pull request
Mar 28, 2023
RIGHT, LEFT, OUTER, INNER, and FULL are HQL tokens. This means they also need to be recognized as potential reserved words and thus possibly identifiers. This can show up if someone, for example, uses "right" as the name of a relationship in a JPA entity. Resolves #2864. Original pull request: #2874.
|
That's rebased, merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.