Skip to content

Fix regression that entityManager can not be intercepted #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix regression that entityManager can not be intercepted #2866

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Mar 17, 2023 •
edited
Loading

Fix GH-2730

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 17, 2023
@mp911de mp911de self-assigned this Mar 27, 2023
@quaff
Copy link
Contributor Author

quaff commented Apr 27, 2023

@mp911de Could you fix this in 3.0.x ASAP?

@spring-projects spring-projects deleted a comment from wanghwtaiji Apr 27, 2023
@quaff quaff mentioned this pull request Jun 10, 2023
Closed
gregturn pushed a commit that referenced this pull request Jun 14, 2023
@quaff @gregturn
Remove synthetic attribute from SharedEntityManager.
3409ee0 
AOT no longer needs this bean to be synthetic to work properly. And this attribute hampers BeanPostProcessors from being applied.

See #2730
Original Pull Request: #2866
gregturn pushed a commit that referenced this pull request Jun 14, 2023
@quaff @gregturn
Remove synthetic attribute from SharedEntityManager.
f25c24f 
AOT no longer needs this bean to be synthetic to work properly. And this attribute hampers BeanPostProcessors from being applied.

See #2730
Original Pull Request: #2866
gregturn pushed a commit that referenced this pull request Jun 14, 2023
@quaff @gregturn
Remove synthetic attribute from SharedEntityManager.
22037f7 
AOT no longer needs this bean to be synthetic to work properly. And this attribute hampers BeanPostProcessors from being applied.

See #2730
Original Pull Request: #2866
@gregturn gregturn added type: regression A regression from a previous release theme: aot and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 14, 2023
@gregturn gregturn closed this Jun 14, 2023
@gregturn
Copy link
Contributor

Merged to main, backported to 3.1.x and 3.0.x

@gregturn
Copy link
Contributor

Thanks @quaff!

@gregturn gregturn added this to the 3.0.7 (2022.0.7) milestone Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
theme: aot type: regression A regression from a previous release
Projects
None yet
Milestone
3.0.7 (2022.0.7)
Development

Successfully merging this pull request may close these issues.

Remove Shared EntityManager's synthetic setting to support bean post processing.
4 participants
@quaff @gregturn @mp911de @spring-projects-issues