DATAJPA-1061 - Fix Sorting doesn't work for field alias. #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract field aliases in QueryUtils and add them in the set of possible sort criterias
|
@GregoireDruant Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@GregoireDruant Thank you for signing the Contributor License Agreement! |
|
@dsyer is it possible review this PR? I have this problem. |
|
What is the status of this PR? When can it be merged? |
schauder
pushed a commit
that referenced
this pull request
Jun 24, 2019
Extract field aliases in QueryUtils and add them in the set of possible sort criteria. Original pull request: #276.
schauder
added a commit
that referenced
this pull request
Jun 24, 2019
Tweaked the formatting and the naming of variables. Original pull request: #276.
schauder
pushed a commit
that referenced
this pull request
Jun 24, 2019
Extract field aliases in QueryUtils and add them in the set of possible sort criteria. Original pull request: #276.
schauder
added a commit
that referenced
this pull request
Jun 24, 2019
Tweaked the formatting and the naming of variables. Original pull request: #276.
schauder
pushed a commit
that referenced
this pull request
Jun 24, 2019
Extract field aliases in QueryUtils and add them in the set of possible sort criteria. Original pull request: #276.
schauder
added a commit
that referenced
this pull request
Jun 24, 2019
Tweaked the formatting and the naming of variables. Original pull request: #276.
|
This is polished, rebased onto master and backported. Thanks for the patience. |
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
Extract field aliases in QueryUtils and add them in the set of possible sort criteria. Original pull request: spring-projects#276.
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
Tweaked the formatting and the naming of variables. Original pull request: spring-projects#276.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract field aliases in QueryUtils and add them in the set of possible sort criterias, to enable the possibility to sort query results based on fields' aliases.