Skip to content

DATAJPA-1335 add missing @override annotations #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ public Instant convertToEntityAttribute(Date date) {
@Converter(autoApply = true)
public static class ZoneIdConverter implements AttributeConverter<ZoneId, String> {

@Override
public String convertToDatabaseColumn(ZoneId zoneId) {
return ZoneIdToStringConverter.INSTANCE.convert(zoneId);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public abstract class AbstractPersistable<PK extends Serializable> implements Pe
* @see org.springframework.data.domain.Persistable#getId()
*/
@Nullable
@Override
public PK getId() {
return id;
}
Expand All @@ -66,6 +67,7 @@ protected void setId(@Nullable PK id) {
* @see org.springframework.data.domain.Persistable#isNew()
*/
@Transient // DATAJPA-622
@Override
public boolean isNew() {
return null == getId();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public static <T> Specifications<T> where(@Nullable Specification<T> spec) {
* @return
*/
@Deprecated
@Override
public Specifications<T> and(@Nullable Specification<T> other) {
return new Specifications<>(composed(spec, other, AND));
}
Expand All @@ -87,6 +88,7 @@ public Specifications<T> and(@Nullable Specification<T> other) {
* @return
*/
@Deprecated
@Override
public Specifications<T> or(@Nullable Specification<T> other) {
return new Specifications<>(composed(spec, other, OR));
}
Expand All @@ -109,6 +111,7 @@ public static <T> Specifications<T> not(@Nullable Specification<T> spec) {
* @see org.springframework.data.jpa.domain.Specification#toPredicate(javax.persistence.criteria.Root, javax.persistence.criteria.CriteriaQuery, javax.persistence.criteria.CriteriaBuilder)
*/
@Nullable
@Override
public Predicate toPredicate(Root<T> root, CriteriaQuery<?> query, CriteriaBuilder builder) {
return spec == null ? null : spec.toPredicate(root, query, builder);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ public enum PersistenceProvider implements QueryExtractor, ProxyIdAccessor {
Arrays.asList(HIBERNATE_ENTITY_MANAGER_INTERFACE), //
Arrays.asList(HIBERNATE_JPA_METAMODEL_TYPE)) {

@Override
public String extractQueryString(Query query) {
return HibernateUtils.getHibernateQuery(query);
}
Expand Down Expand Up @@ -118,6 +119,7 @@ public CloseableIterator<Object> executeQueryWithResultStream(Query jpaQuery) {
*/
ECLIPSELINK(Collections.singleton(ECLIPSELINK_ENTITY_MANAGER_INTERFACE), Collections.singleton(ECLIPSELINK_JPA_METAMODEL_TYPE)) {

@Override
public String extractQueryString(Query query) {
return ((JpaQuery<?>) query).getDatabaseQuery().getJPQLString();
}
Expand Down Expand Up @@ -316,6 +318,7 @@ private static PersistenceProvider cacheAndReturn(Class<?> type, PersistenceProv
* (non-Javadoc)
* @see org.springframework.data.jpa.repository.query.QueryExtractor#canExtractQuery()
*/
@Override
public boolean canExtractQuery() {
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,24 +39,28 @@ public interface JpaRepository<T, ID> extends PagingAndSortingRepository<T, ID>,
* (non-Javadoc)
* @see org.springframework.data.repository.CrudRepository#findAll()
*/
@Override
List<T> findAll();

/*
* (non-Javadoc)
* @see org.springframework.data.repository.PagingAndSortingRepository#findAll(org.springframework.data.domain.Sort)
*/
@Override
List<T> findAll(Sort sort);

/*
* (non-Javadoc)
* @see org.springframework.data.repository.CrudRepository#findAll(java.lang.Iterable)
*/
@Override
List<T> findAllById(Iterable<ID> ids);

/*
* (non-Javadoc)
* @see org.springframework.data.repository.CrudRepository#save(java.lang.Iterable)
*/
@Override
<S extends T> List<S> saveAll(Iterable<S> entities);

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public class AuditingBeanDefinitionParser implements BeanDefinitionParser {
* (non-Javadoc)
* @see org.springframework.beans.factory.xml.BeanDefinitionParser#parse(org.w3c.dom.Element, org.springframework.beans.factory.xml.ParserContext)
*/
@Override
public BeanDefinition parse(Element element, ParserContext parser) {

springConfiguredParser.parse(element, parser);
Expand Down Expand Up @@ -92,6 +93,7 @@ private static class SpringConfiguredBeanDefinitionParser implements BeanDefinit

private static final String BEAN_CONFIGURER_ASPECT_CLASS_NAME = "org.springframework.beans.factory.aspectj.AnnotationBeanConfigurerAspect";

@Override
public BeanDefinition parse(Element element, ParserContext parserContext) {

if (!parserContext.getRegistry().containsBeanDefinition(BEAN_CONFIGURER_ASPECT_BEAN_NAME)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ public void registerBeansForRoot(BeanDefinitionRegistry registry, RepositoryConf
* (non-Javadoc)
* @see org.springframework.data.repository.config.RepositoryConfigurationExtensionSupport#getConfigurationInspectionClassLoader(org.springframework.core.io.ResourceLoader)
*/
@Override
protected ClassLoader getConfigurationInspectionClassLoader(ResourceLoader loader) {

ClassLoader classLoader = loader.getClassLoader();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public class JpaRepositoryNameSpaceHandler extends NamespaceHandlerSupport {
*
* @see org.springframework.beans.factory.xml.NamespaceHandler#init()
*/
@Override
public void init() {

RepositoryConfigurationExtension extension = new JpaRepositoryConfigExtension();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ class NamedOrIndexedQueryParameterSetter implements QueryParameterSetter {
* @see org.springframework.data.jpa.repository.query.QueryParameterSetter#setParameter(javax.persistence.Query, java.lang.Object[])
*/
@SuppressWarnings("unchecked")
@Override
public void setParameter(Query query, Object[] values, ErrorHandling errorHandling) {

Object value = valueExtractor.apply(values);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ enum CrudMethodMetadataPopulatingMethodInterceptor implements MethodInterceptor
* (non-Javadoc)
* @see org.aopalliance.intercept.MethodInterceptor#invoke(org.aopalliance.intercept.MethodInvocation)
*/
@Override
public Object invoke(MethodInvocation invocation) throws Throwable {

Method method = invocation.getMethod();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ public JpaEntityInformationSupport(Class<T> domainClass) {
* (non-Javadoc)
* @see org.springframework.data.jpa.repository.support.JpaEntityMetadata#getEntityName()
*/
@Override
public String getEntityName() {
return metadata.getEntityName();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ public String getEntityName() {
* (non-Javadoc)
* @see org.springframework.data.repository.core.EntityInformation#getId(java.lang.Object)
*/
@Override
@Nullable
@SuppressWarnings("unchecked")
public ID getId(T entity) {
Expand Down Expand Up @@ -173,6 +174,7 @@ public ID getId(T entity) {
* (non-Javadoc)
* @see org.springframework.data.repository.core.EntityInformation#getIdType()
*/
@Override
@SuppressWarnings("unchecked")
public Class<ID> getIdType() {
return (Class<ID>) idMetadata.getType();
Expand All @@ -182,6 +184,7 @@ public Class<ID> getIdType() {
* (non-Javadoc)
* @see org.springframework.data.jpa.repository.support.JpaEntityInformation#getIdAttribute()
*/
@Override
public SingularAttribute<? super T, ?> getIdAttribute() {
return idMetadata.getSimpleIdAttribute();
}
Expand All @@ -190,6 +193,7 @@ public Class<ID> getIdType() {
* (non-Javadoc)
* @see org.springframework.data.jpa.repository.support.JpaEntityInformation#hasCompositeId()
*/
@Override
public boolean hasCompositeId() {
return !idMetadata.hasSimpleId();
}
Expand All @@ -198,6 +202,7 @@ public boolean hasCompositeId() {
* (non-Javadoc)
* @see org.springframework.data.jpa.repository.support.JpaEntityInformation#getIdAttributeNames()
*/
@Override
public Iterable<String> getIdAttributeNames() {

List<String> attributeNames = new ArrayList<String>(idMetadata.attributes.size());
Expand All @@ -213,6 +218,7 @@ public Iterable<String> getIdAttributeNames() {
* (non-Javadoc)
* @see org.springframework.data.jpa.repository.support.JpaEntityInformation#getCompositeIdAttributeValue(java.lang.Object, java.lang.String)
*/
@Override
public Object getCompositeIdAttributeValue(Object id, String idAttribute) {

Assert.isTrue(hasCompositeId(), "Model must have a composite Id!");
Expand Down Expand Up @@ -305,6 +311,7 @@ private static Class<?> fallbackIdTypeLookup(IdentifiableType<?> type) {
* (non-Javadoc)
* @see java.lang.Iterable#iterator()
*/
@Override
public Iterator<SingularAttribute<? super T, ?>> iterator() {
return attributes.iterator();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ public void afterPropertiesSet() {
* (non-Javadoc)
* @see org.springframework.data.repository.core.support.TransactionalRepositoryFactoryBeanSupport#setBeanFactory(org.springframework.beans.factory.BeanFactory)
*/
@Override
public void setBeanFactory(BeanFactory beanFactory) {

Assert.isInstanceOf(ListableBeanFactory.class, beanFactory);
Expand Down
Loading