Skip to content

Remove 'fetch' part in 'join fetch' clause during generation of count query #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yukharin
Copy link
Contributor

@yukharin yukharin commented Nov 1, 2022

Closes #2348

  • [+] You have read the Spring Data contribution guidelines.
  • [+] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [+] You submit test cases (unit or integration tests) that back your changes.
  • [+] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 1, 2022
@yukharin
Copy link
Contributor Author

yukharin commented Nov 1, 2022

I've tested this fix on some real project and it works fine.
But if there is a need to add integration tests, please, let me know)

@gregturn gregturn added the in: query-parser Everything related to parsing JPQL or SQL label Jan 25, 2023
@gregturn gregturn added revisit-after-parser-rewrite and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 27, 2023
@gregturn
Copy link
Contributor

We are working on a parsing solution to better handle such situations than QueryUtils accommodates. For the meantime, we are trying to avoid any more changes to QueryParser.

gregturn added a commit that referenced this pull request Mar 22, 2023
@gregturn
Copy link
Contributor

Superseded by #2883.

@gregturn gregturn closed this Mar 22, 2023
schauder pushed a commit that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: query-parser Everything related to parsing JPQL or SQL revisit-after-parser-rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

count query fails to be auto generated when using @Query annotation with fetch join
3 participants