Fixed EntityGraphFactory overwriting subgraphs

[pstrnad]

EntityGraphFactory doesn't check whether a subgraph for a joined entity has already been created, and instead always creates a new one which overwrites the previous one.

E.g. when properties "a.b.field" and "a.c.field" are passed, it will first create a subgraph for "a" with a nested subgraph for "b", then create a new subgraph for "a" with a nested subgraph for "c", which will replace the the previous subgraph for "a". Therefore, no eager join for the b entity will be generated.

Related ticket #2527

• You have read the Spring Data contribution guidelines.
• You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
• You submit test cases (unit or integration tests) that back your changes.
• You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

[pivotal-cla]

@pstrnad Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-cla]

@pstrnad Thank you for signing the Contributor License Agreement!

[laszlopalfi]

any updates on this?

[gregturn]

Thanks @pstrnad!

[gregturn]

It's been merged to main and backported to 3.0.x.