Skip to content

JSqlParserQueryEnhancer works with non Select Statements. #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DiegoKrupitza
Copy link
Contributor

Previously this implementation of QueryEnhancer could not handle non Select statements (such as Delete, Update, ...). With this commit we do handle them. Keep in mind that "enhancing" non selects does not have any effect on them (and the current default implementation QueryUtils does not care either aka it often just returns the same query, null or empty string).

Closes: #2555

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Previously this implementation of `QueryEnhancer` could not handle non Select statements (such as Delete, Update, ...). With this commit we do handle them. Keep in mind that "enhancing" non selects does not have any effect on them (and the current default implementation `QueryUtils` does not care either aka it often just returns the same query, null or empty string).

Closes: spring-projects#2555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSqlParser fails for modifying queries
3 participants