Skip to content

Fix case where the from clause is misidentified. #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

darinmanica
Copy link
Contributor

Fix case where the from clause is misidentified.
fixes #2260

Added a zero-width word boundary to the regex that identifies the from clause. This is used in alias detection for order by clauses.

  • [✓] You have read the Spring Data contribution guidelines.
  • [✓] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [✓] You submit test cases (unit or integration tests) that back your changes.
  • [✓] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

fixes spring-projects#2260

Added a zero-width word boundary to the regex that identifies the from clause.  This is used in alias detection for order by clauses.
@gregturn
Copy link
Contributor

gregturn commented May 5, 2022

Thanks @darinmanica!

Your solution was much simpler than mine.

Future tip: If you could submit PRs against main instead of 2.6.x, it makes the process to review and then backport to supported branches much easier.

@gregturn gregturn removed the status: waiting-for-triage An issue we've not yet triaged label May 5, 2022
@gregturn gregturn self-assigned this May 5, 2022
@gregturn gregturn closed this May 5, 2022
@darinmanica
Copy link
Contributor Author

Thank you @gregturn! I'll be sure to submit PRs against main going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants