DATAJPA-1267 - Using SpEL infrastructure from commons. #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
force-pushed
the
issue/DATAJPA-1267
branch
from
a5a9332 to
ff3a695
Compare
With DATACMNS-1258 handling of SpEL expressions in queries was moved to SD-Commons. This change now uses that infrastructure and removes the parts no longer necessary in this repository.
Simplified code. Reduced scope of constants that are really only useful in a tight scope. Converted tests to AssertJ. Added issue comments on tests.
Adapt to polished API for DATACMNS-1258. Related tickets: DATACMNS-1258.
schauder
force-pushed
the
issue/DATAJPA-1267
branch
from
ff3a695 to
0bf24ad
Compare
mp911de
pushed a commit
that referenced
this pull request
Jul 23, 2018
With DATACMNS-1258 handling of SpEL expressions in queries was moved to SD-Commons. This change now uses that infrastructure and removes the parts no longer necessary in this repository. Original pull request: #250.
mp911de
pushed a commit
that referenced
this pull request
Jul 23, 2018
Adapt to polished API for DATACMNS-1258. Related tickets: DATACMNS-1258. Original pull request: #250.
mp911de
pushed a commit
that referenced
this pull request
Jul 23, 2018
Original pull request: #250. Related ticket: DATAJPA-1307.
mp911de
added a commit
that referenced
this pull request
Jul 23, 2018
Tweak error messages. Make method static where possible. Typos. Original pull request: #250.
|
That's merged and polished now. |
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
With DATACMNS-1258 handling of SpEL expressions in queries was moved to SD-Commons. This change now uses that infrastructure and removes the parts no longer necessary in this repository. Original pull request: spring-projects#250.
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
Adapt to polished API for DATACMNS-1258. Related tickets: DATACMNS-1258. Original pull request: spring-projects#250.
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
Original pull request: spring-projects#250. Related ticket: DATAJPA-1307.
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
Tweak error messages. Make method static where possible. Typos. Original pull request: spring-projects#250.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on DATACMNS-1258 (spring-projects/spring-data-commons#275) which needs to get merged first.
With DATACMNS-1258 handling of SpEL expressions in queries was moved to SD-Commons.
This change now uses that infrastructure and removes the parts no longer necessary in this repository.