Skip to content

Added exists method with specification to JpaSpecificationExecutor. #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DiegoKrupitza
Copy link
Contributor

It is now possible to make existence checks with Specifications. This is an addition to checking existence with using an Example.

Closes #2388

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

It is now possible to make existence checks with `Specification`s. This is an addition to checking existence with using an `Example`.

Closes spring-projects#2388
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 21, 2022
@schauder schauder self-assigned this Feb 22, 2022
@schauder schauder added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 22, 2022
schauder pushed a commit that referenced this pull request Feb 22, 2022
It is now possible to make existence checks based on a `Specification`. This is an addition to checking existence with using an `Example`.

Closes #2388
Original pull request #2449
schauder added a commit that referenced this pull request Feb 22, 2022
Fixed import formatting.
Removed (non-Javadoc) comment, since we don't use them anymore.
Simplified some code and removed superfluous or wrong Javadoc in touched files.
Formatting.

See #2388
Original pull request #2449
@DiegoKrupitza
Copy link
Contributor Author

@schauder
Question becasue of commit (af28245).

I use the import order and code format file from here but it seems to be not correct. Therefore I wanted to ask if this style guide is the correct one (since it is also listed in the contribution guidelines) or am I'm doing something wrong?

schauder pushed a commit that referenced this pull request Feb 22, 2022
It is now possible to make existence checks based on a `Specification`. This is an addition to checking existence with using an `Example`.

Closes #2388
Original pull request #2449
schauder added a commit that referenced this pull request Feb 22, 2022
Fixed import formatting.
Removed (non-Javadoc) comment, since we don't use them anymore.
Simplified some code and removed superfluous or wrong Javadoc in touched files.
Formatting.

See #2388
Original pull request #2449
@schauder
Copy link
Contributor

Thanks

That's merged, polished and ported to 3.0.x.

@schauder schauder closed this Feb 22, 2022
@schauder
Copy link
Contributor

@schauder Question becasue of commit (af28245).

I use the import order and code format file from here but it seems to be not correct. Therefore I wanted to ask if this style guide is the correct one (since it is also listed in the contribution guidelines) or am I'm doing something wrong?

That is very much correct, but it requires some extra settings mentioned at the bottom.
Specifically this one seems to be off/missing in your configuration

Class count to use import with *: 10

@DiegoKrupitza
Copy link
Contributor Author

@schauder Question becasue of commit (af28245).
I use the import order and code format file from here but it seems to be not correct. Therefore I wanted to ask if this style guide is the correct one (since it is also listed in the contribution guidelines) or am I'm doing something wrong?

That is very much correct, but it requires some extra settings mentioned at the bottom. Specifically this one seems to be off/missing in your configuration

Class count to use import with *: 10

Ok thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add exists method to JpaSpecificationExecutor
3 participants