Skip to content

Support compound IdClass ID's when calling deleteAllByIdInBatch. #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ejl888
Copy link
Contributor

@ejl888 ejl888 commented Jan 25, 2022

Convert ID's to entities and pass them to deleteAllInBatch.

Fixes #2414

  • [v ] You have read the Spring Data contribution guidelines.
  • [ v] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [ v] You submit test cases (unit or integration tests) that back your changes.
  • [ v] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Convert ID's to entities and pass them to deleteAllInBatch.

Fixes spring-projects#2414
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 25, 2022
schauder pushed a commit that referenced this pull request Feb 8, 2022
Convert ID's to entities and pass them to deleteAllInBatch.

Closes #2414
Original pull request #2419
schauder added a commit that referenced this pull request Feb 8, 2022
Formatting.

See #2414
Original pull request #2419
schauder added a commit that referenced this pull request Feb 8, 2022
Formatting.
Fix warnings.

See #2414
Original pull request #2419
@schauder
Copy link
Contributor

schauder commented Feb 8, 2022

Thanks, that's polished and merged.

@schauder schauder closed this Feb 8, 2022
schauder added a commit that referenced this pull request Feb 8, 2022
Formatting.
Fix warnings.

See #2414
Original pull request #2419
schauder pushed a commit that referenced this pull request Feb 8, 2022
Convert ID's to entities and pass them to deleteAllInBatch.

Closes #2414
Original pull request #2419
schauder added a commit that referenced this pull request Feb 8, 2022
Formatting.
Fix warnings.

See #2414
Original pull request #2419
schauder pushed a commit that referenced this pull request Feb 8, 2022
Convert ID's to entities and pass them to deleteAllInBatch.

Closes #2414
Original pull request #2419
schauder added a commit that referenced this pull request Feb 8, 2022
Formatting.
Fix warnings.

See #2414
Original pull request #2419
schauder pushed a commit that referenced this pull request Feb 15, 2022
Convert ID's to entities and pass them to deleteAllInBatch.

Closes #2414
Original pull request #2419
schauder added a commit that referenced this pull request Feb 15, 2022
Formatting.
Fix warnings.

See #2414
Original pull request #2419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JpaRepository#deleteAllByIdInBatch fails when (compound) IdClass keys are used
3 participants