Skip to content

Properly handle Sort.Order for a select field alias. #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Properly handle Sort.Order for a select field alias. #2399

wants to merge 2 commits into from

Conversation

gregturn
Copy link
Contributor

@gregturn gregturn commented Jan 4, 2022

No description provided.

@gregturn
GH-2280 - Prepare branch
624464b
@gregturn
Propertly handle ignoreCase for aliased fields.
b22151c 
When writing a select with a field alias, properly handle Sort.Order's ignoreCase.

Closes #2280.
@gregturn gregturn requested a review from schauder January 4, 2022 17:59
@gregturn gregturn mentioned this pull request Jan 4, 2022
Closed
schauder pushed a commit that referenced this pull request Jan 5, 2022
@gregturn @schauder
Properly handle ignoreCase for aliased fields.
27f6866 
When writing a select with a field alias, properly handle Sort.Order's ignoreCase.

Closes #2280
Original pull request #2399
schauder added a commit that referenced this pull request Jan 5, 2022
@schauder
Polishing.
8c4123f 
Minor formatting.

See #2280
Original pull request #2399
schauder pushed a commit that referenced this pull request Jan 5, 2022
@gregturn @schauder
Properly handle ignoreCase for aliased fields.
0813bc2 
When writing a select with a field alias, properly handle Sort.Order's ignoreCase.

Closes #2280
Original pull request #2399
schauder added a commit that referenced this pull request Jan 5, 2022
@schauder
Polishing.
7fe5ede 
Minor formatting.

See #2280
Original pull request #2399
schauder pushed a commit that referenced this pull request Jan 5, 2022
@gregturn @schauder
Properly handle ignoreCase for aliased fields.
a030d87 
When writing a select with a field alias, properly handle Sort.Order's ignoreCase.

Closes #2280
Original pull request #2399
schauder added a commit that referenced this pull request Jan 5, 2022
@schauder
Polishing.
a3cfd19 
Minor formatting.

See #2280
Original pull request #2399
@schauder schauder closed this Jan 5, 2022
@schauder schauder deleted the issue/GH-2280 branch January 5, 2022 08:48
@schauder
Copy link
Contributor

schauder commented Jan 5, 2022

Thanks, this is polished, merged and backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schauder schauder Awaiting requested review from schauder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregturn @schauder