Skip to content

Destroy docker container properly #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Destroy docker container properly #2379

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Dec 6, 2021

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 6, 2021
@schauder
Copy link
Contributor

schauder commented Dec 6, 2021

Thanks for the PR.

Maybe I'm a little slow on Monday morning, but I fail to see what problem this PR is solving. Could you please elaborate?

@schauder schauder added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 6, 2021
@quaff
Copy link
Contributor Author

quaff commented Dec 6, 2021

Thanks for the PR.

Maybe I'm a little slow on Monday morning, but I fail to see what problem this PR is solving. Could you please elaborate?

After this commit, container which implements AutoCloseable is created as spring bean, it will be closed when spring context close.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 6, 2021
schauder pushed a commit that referenced this pull request Dec 6, 2021
@quaff @schauder
Destroy docker container properly.
7509acd 
Since JdbcContaieners are AutoClosables Spring will call `close()` on shut down.

Original pull request #2379
schauder added a commit that referenced this pull request Dec 6, 2021
@schauder
Polishing.
732a25c 
Code formatting.

Original pull request #2379
schauder pushed a commit that referenced this pull request Dec 6, 2021
@quaff @schauder
Destroy docker container properly.
d49f0ca 
Since JdbcContaieners are AutoClosables Spring will call `close()` on shut down.

Original pull request #2379
schauder added a commit that referenced this pull request Dec 6, 2021
@schauder
Polishing.
5c7a00e 
Code formatting.

Original pull request #2379
@schauder
Copy link
Contributor

schauder commented Dec 6, 2021

Thanks. That's merged.

@schauder schauder closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: feedback-provided Feedback has been provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quaff @schauder @spring-projects-issues