changes based on the results of static code analysis by Findbugs #2324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dk2k Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
What do I do now to restart checks? |
spring-projects-issues
added
the
status: waiting-for-triage
|
@dk2k Thank you for signing the Contributor License Agreement! |
mp911de
reviewed
Oct 6, 2021
|
|
||
| return classLoader != null && LazyJvmAgent.isActive(loader.getClassLoader()) | ||
| AtomicReference<ClassLoader> classLoaderRef = new AtomicReference<>(); | ||
| AccessController.doPrivileged(new PrivilegedAction() { |
There was a problem hiding this comment.
AccessController is subject to deprecation and future removal with the deprecation of Java's Security Manager.
There was a problem hiding this comment.
will revert related changes then
mp911de
reviewed
Oct 13, 2021
| @@ -160,7 +160,7 @@ | |||
| PathNode node = currentNode.add(attribute.getName(), attributeValue); | |||
| if (node.spansCycle()) { | |||
| throw new InvalidDataAccessApiUsageException( | |||
| String.format("Path '%s' from root %s must not span a cyclic property reference!\r\n%s", currentPath, | |||
| String.format("Path '%s' from root %s must not span a cyclic property reference!%n%s", currentPath, | |||
There was a problem hiding this comment.
From a general perspective, we should avoid linebreaks in exceptions. That's something we need to address within the team.
|
Thanks, that's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for removed Assert - its condition is always true, can be checked in Intellij Idea as well