Skip to content

DATAJPA-1574 - Add support for saveAllAndFlush. #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

skrabbenborg
Copy link
Contributor

@skrabbenborg skrabbenborg commented Feb 3, 2021

Closes #1883

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 3, 2021
@skrabbenborg
Copy link
Contributor Author

Would it be advisable to add a statement in the javadoc that saveAll() and flush() are used, thus overriding those methods will also change the functionality of this method?

@mp911de
Copy link
Member

mp911de commented Feb 3, 2021

We typically don't document these things. It gives us a certain freedom to change the actual implementation. You could add @see #saveall and @see #flush references.

@schauder schauder self-assigned this Feb 8, 2021
@schauder schauder self-requested a review February 8, 2021 16:19
schauder pushed a commit that referenced this pull request Feb 25, 2021
Closes #1883
Original pull request #2148
schauder added a commit that referenced this pull request Feb 25, 2021
Adding and correcting `@since` annotations.
Cleaning up some JavaDoc.
Tweaking some tests to make them more precise.

Original pull request #2148
@schauder
Copy link
Contributor

Thanks for your work. That's polished and merged.

@schauder schauder closed this Feb 25, 2021
@schauder schauder added this to the 2.5 RC1 (2021.0.0) milestone Feb 25, 2021
@schauder schauder added in: repository Repositories abstraction type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: repository Repositories abstraction type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

saveAndFlush could accept iterable as well [DATAJPA-1574]
4 participants